Conversation
Contributor
|
Valgrind Results: |
gakonst
added a commit
to paradigmxyz/reth
that referenced
this pull request
May 17, 2024
Collaborator
|
Found & fixed the bug and updated PR description. Feel free to improve on my code (esp the empty slice check is ugly but it's 330am). This should be functional for Devnet-0. There might be better ways to work around this massive BLST footgun but don't have the time for this rn. |
DaniPopes
reviewed
May 17, 2024
DaniPopes
reviewed
May 17, 2024
rakita
approved these changes
May 17, 2024
Member
rakita
left a comment
There was a problem hiding this comment.
Pending some discussion, PR lgtm
these should be added again at some point
DaniPopes
reviewed
May 17, 2024
rakita
reviewed
May 17, 2024
Closed
This was referenced May 24, 2024
Closed
Closed
Closed
Closed
This was referenced May 31, 2024
Closed
Closed
Closed
This was referenced Jun 6, 2024
Closed
Closed
Closed
This was referenced Jun 17, 2024
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a process failure from our side:
Makes me think we may want to subscribe to specific EIP updates in an internal channel to ensure we don't miss anything.