feat: implement DatabaseCommit for DatabaseComponents #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rakita
reviewed
Mar 7, 2024
| @@ -3,13 +3,16 @@ pub mod block_hash; | |||
| pub mod state; | |||
|
|
|||
| pub use block_hash::{BlockHash, BlockHashRef}; | |||
| use hashbrown::HashMap; | |||
There was a problem hiding this comment.
Suggested change
| use hashbrown::HashMap; | |
| use crate::HashMap; |
When std is enabled we are using std HashMap so in all places in code we include hashmap as crate::HashMap
Merged
fubuloubu
pushed a commit
to ApeWorX/revm
that referenced
this pull request
Apr 11, 2024
* feat: implement DatabaseCommit for DatabaseComponents * misc: apply review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These implementations were missing when working with a type that implements
DatabaseRefinstead ofDatabase