allow for s3 endpoint param #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chouhanyang: Is it possible to merge this PR? |
|
This would be really useful. DigitalOcean has also started their Object-Storage service that works flawlessly with s3cmd. Only thing stopping S4cmd form working with DigitalOcean and other providers is the 'endpoint_url'. |
|
Someone apply this patch it has saved me a lot of trouble, and I don't see it negatively affecting anything else upstream. Thank you @apbodnar for doing the work on this. |
|
@chouhanyang can you please merge this pr? |
nglange
approved these changes
Feb 21, 2018
cgroschupp
approved these changes
Feb 21, 2018
|
Why was this not yet merged? :) |
|
+1 T.T |
|
Hi, @apbodnar Thanks for the pull request. I am trying to revive this project and would like to validate the use case with a test case. Is it possible for you to share the steps required for testing this feature? |
|
Thanks! |
This was referenced May 17, 2018
Closed
VarunWachaspati
pushed a commit
to VarunWachaspati/s4cmd
that referenced
this pull request
Oct 10, 2020
allow for s3 endpoint param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to use s3 transfer accelerated buckets with s4cmd. Boto3 allows for this by configuring a
endpoint_urlin the s3 client. With this change, I can enable s3 transfer acceleration by using--endpoint-url=http://s3-accelerate.amazonaws.com