Skip to content

Various style fixes and cleanup#15

Merged
dprophet merged 1 commit intobloomberg:snowflakefrom
martint:pr17909
Dec 21, 2023
Merged

Various style fixes and cleanup#15
dprophet merged 1 commit intobloomberg:snowflakefrom
martint:pr17909

Conversation

@martint
Copy link
Copy Markdown

@martint martint commented Dec 20, 2023

Apply comments from trinodb#17909

Copy link
Copy Markdown
Member

@dprophet dprophet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@dprophet dprophet merged commit 36920e0 into bloomberg:snowflake Dec 21, 2023
@martint martint deleted the pr17909 branch December 21, 2023 18:28
dprophet pushed a commit that referenced this pull request Jan 10, 2024
Co-authored-by: Martin Traverso <mtraverso@gmail.com>
dprophet pushed a commit that referenced this pull request Feb 23, 2024
Various style fixes and cleanup (#15) (#17)

Co-authored-by: Martin Traverso <mtraverso@gmail.com>
Various style fixes and cleanup (#15)

Update the github CI (#12)

* Add Snowflake JDBC Connector

* Add snowflake in the ci
Add Snowflake JDBC Connector (#11)

Had to redo the connector because all the rebases caused havoc
dprophet pushed a commit that referenced this pull request Mar 4, 2024
*****

Update ci and delete no use lines (#20)

Approved
Update according to reviews 11/01/2024

Various style fixes and cleanup (#15) (#17)

Co-authored-by: Martin Traverso <mtraverso@gmail.com>
Various style fixes and cleanup (#15)

Update the github CI (#12)

* Add Snowflake JDBC Connector

* Add snowflake in the ci
Add Snowflake JDBC Connector (#11)

Had to redo the connector because all the rebases caused havoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants