Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored GenericFuture class using variants. Provide runtime check … #142

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Refactored GenericFuture class using variants. Provide runtime check … #142

merged 1 commit into from
Jan 8, 2021

Conversation

accelerated
Copy link
Contributor

Describe your changes

  • Refactored GenericFuture class using variants for C++17 only.
  • Provide runtime check for inadvertent coroutine blocking. This will assert when a coroutine context is present and the application tries to execute a blocking call via the GenericFuture class.
  • Provided better exception error messages.

Signed-off-by: Alexander Damian [email protected]

Refactored GenericFuture class using variants. Provide runtime check …
914049d 
…for inadvertent coroutine blocking.

Signed-off-by: Alexander Damian <[email protected]>
arosenzweig3
arosenzweig3 approved these changes Jan 8, 2021
View reviewed changes
Copy link
Contributor

@arosenzweig3 arosenzweig3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@accelerated accelerated merged commit eab39b6 into bloomberg:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arosenzweig3 arosenzweig3 arosenzweig3 approved these changes

@albertdang2 albertdang2 Awaiting requested review from albertdang2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@accelerated @arosenzweig3