Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set generation from ckp-logs 8.0 #4908

Open
wants to merge 1 commit into
base: 8.0
Choose a base branch
from

Conversation

markhannum
Copy link
Contributor

@markhannum markhannum commented Dec 14, 2024

Not writing rep-gen transaction records from full-recovery opened up situations where a node coming up would be able to see the most recently written generation only from checkpoint records. Because of this bug, it would then start to emit records at a lower generation than had been previously seen.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Signed-off-by: Mark Hannum <[email protected]>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 7/563 tests failed ⚠.

The first 10 failing tests are:
phys_rep_perf
logarchive
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys
sc_downgrade
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 7/563 tests failed ⚠.

The first 10 failing tests are:
analyze_fastinit_race
phys_rep_perf
logarchive
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/563 tests failed ⚠.

The first 10 failing tests are:
analyze_fastinit_race
phys_rep_perf
sc_resume2
logarchive
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys
truncatesc_offline_generated

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

@akshatsikarwar akshatsikarwar changed the title Set generation from ckp-logs Set generation from ckp-logs 8.0 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants