Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Tweaking the current_connections metric #4819

Open
wants to merge 1 commit into
base: 8.0
Choose a base branch
from

Conversation

riverszhang89
Copy link
Contributor

This patch excludes connections owned by either sockpool or the in-process cache from the current_connections metric. This is one of the metrics that we use internally to monitor database capacity. Since it is very little overhead for libevent based network to maintain idle connections, it makes sense to exclude pooled connections from the metric.

@riverszhang89 riverszhang89 added the R8 Affects version R8 label Nov 5, 2024
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 8/559 tests failed ⚠.

The first 10 failing tests are:
timepart_retention1 [setup failure]
writes_remsql_partial_index_off_generated [setup failure]
writes_remsql_names_fdbpush_generated [setup failure]
verify_error [setup failure]
analyze_fastinit_race
comdb2sys_pagesize_generated
comdb2sys
truncatesc_offline_generated

This patch excludes connections owned by either sockpool or the in-process cache from
the current_connections metric. This is one of the metrics that we use internally to
monitor database capacity. Since it is very little overhead for libevent based network
to maintain idle connections, it makes sense to exclude donated connections from the metric.

Signed-off-by: Rivers Zhang <[email protected]>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 2/558 tests failed ⚠.

The first 10 failing tests are:
sc_dbstore_func
truncatesc_offline_generated

@riverszhang89
Copy link
Contributor Author

cdb2test   Nov  5 22:01:20 2024        error appsockcount8.R20241105.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R8 Affects version R8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants