Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log long running SQLs executed from a stored procedure #4754

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

log long running SQLs executed from a stored procedure #4754

wants to merge 1 commit into from
+95 −4

Conversation

aakash10292
Copy link
Contributor

No description provided.

roborivers
roborivers suggested changes Oct 8, 2024
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 7/585 tests failed ⚠.

The first 10 failing tests are:
misstable_remsql [setup failure]
fdb_push_rte_connect_generated [setup failure]
basic_sslnoproto_generated [setup failure]
analyze_exit_immediately
snap_ha_retry_newsi_generated
union_parallel
dbcreate

@aakash10292 aakash10292 mentioned this pull request Oct 10, 2024
Open
@aakash10292
Copy link
Contributor Author

cdb2test Oct 11 11:13:28 2024 in-comdb2db aar_longreqs.R20241011.2

roborivers
roborivers suggested changes Oct 11, 2024
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 3/585 tests failed ⚠.

The first 10 failing tests are:
sc_newuniq_logicalsc_generated [setup failure]
sorese_tran [setup failure]
snap_ha_retry_newsi_generated

@akshatsikarwar
Copy link
Contributor

Instead of overwriting clnt->sql, how about adding a version of reqlog_end_request which takes the request string. You can get the sql string from the sqlite_stmt object just before it is reset or finalized.

@aakash10292 aakash10292 force-pushed the aar_longreqs branch 2 times, most recently from 515b480 to c1480cd Compare October 21, 2024 19:43
roborivers
roborivers suggested changes Oct 23, 2024
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 9/587 tests failed ⚠.

The first 10 failing tests are:
cldeadlock [setup failure]
sc_timepart_logicalsc_generated [setup failure]
writes_remsql_fdbpush_generated [setup failure]
fdb_push_rte_connect_generated [setup failure]
fdb_push_redirect_generated [setup failure]
analyze_exit_immediately
snapshot_during_truncate
snap_ha_retry_newsi_generated

@aakash10292
Copy link
Contributor Author

cdb2test Oct 22 23:39:56 2024 in-comdb2db aar_longreqs.R20241022.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roborivers roborivers roborivers requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aakash10292 @akshatsikarwar @roborivers