Merge pull request #138 from bloomberg/isolated-declaration-reuse-binder

Remove binder from transpileDeclaration implementation.
bloomberg · Jan 22, 2024 · a9d06d7 · a9d06d7
2 parents 418f975 + dc1ffe9
commit a9d06d7
Show file tree

Hide file tree

Showing 30 changed files with 1,896 additions and 1,716 deletions.
diff --git a/src/compiler/_namespaces/ts.ts b/src/compiler/_namespaces/ts.ts
@@ -57,7 +57,6 @@ export * from "../transformers/module/system";
 export * from "../transformers/module/esnextAnd2015";
 export * from "../transformers/module/node";
 export * from "../transformers/declarations/diagnostics";
-export * from "../transformers/declarations/emitBinder";
 export * from "../transformers/declarations/emitResolver";
 export * from "../transformers/declarations/transpileDeclaration";
 export * from "../transformers/declarations/localInferenceResolver";

diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
diff --git a/src/compiler/debug.ts b/src/compiler/debug.ts
@@ -4,6 +4,7 @@ import {
     AssertionLevel,
     BigIntLiteralType,
     CheckMode,
+    Comparer,
     compareValues,
     EmitFlags,
     every,
@@ -356,15 +357,6 @@ export namespace Debug {
         }
     }
 
-    /**
-     * Asserts the symbol is defined and is of the right kind (originating in TSC or sample DTE depending o the test that is currently being run)
-     * The default implementation just asserts the symbol is not null
-     * In tests it is overridden to ensure we don't accidentally use TSC symbols in DTE
-     */
-    // eslint-disable-next-line prefer-const
-    export let assertSymbolValid = (symbol: Symbol) => {
-        assert(symbol, "Symbol not defined");
-    };
     /**
      * Asserts a value has the specified type in typespace only (does not perform a runtime assertion).
      * This is useful in cases where we switch on `node.kind` and can be reasonably sure the type is accurate, and
@@ -395,18 +387,18 @@ export namespace Debug {
      * Formats an enum value as a string for debugging and debug assertions.
      */
     export function formatEnum(value = 0, enumObject: any, isFlags?: boolean) {
-        const members = getEnumMembers(enumObject);
+        const members = getEnumMembers(enumObject, isFlags);
         if (value === 0) {
             return members.length > 0 && members[0][0] === 0 ? members[0][1] : "0";
         }
         if (isFlags) {
             const result: string[] = [];
             let remainingFlags = value;
             for (const [enumValue, enumName] of members) {
-                if (enumValue > value) {
+                if (enumValue > remainingFlags) {
                     break;
                 }
-                if (enumValue !== 0 && enumValue & value) {
+                if (enumValue !== 0 && enumValue & remainingFlags) {
                     result.push(enumName);
                     remainingFlags &= ~enumValue;
                 }
@@ -427,7 +419,7 @@ export namespace Debug {
 
     const enumMemberCache = new Map<any, SortedReadonlyArray<[number, string]>>();
 
-    function getEnumMembers(enumObject: any) {
+    function getEnumMembers(enumObject: any, isFlags?: boolean) {
         // Assuming enum objects do not change at runtime, we can cache the enum members list
         // to reuse later. This saves us from reconstructing this each and every time we call
         // a formatting function (which can be expensive for large enums like SyntaxKind).
@@ -444,7 +436,10 @@ export namespace Debug {
             }
         }
 
-        const sorted = stableSort<[number, string]>(result, (x, y) => compareValues(x[0], y[0]));
+        const comparer: Comparer<[number, string]> = isFlags ?
+            (x, y) => compareValues(x[0] >>> 0, y[0] >>> 0) :
+            (x, y) => compareValues(x[0], y[0]);
+        const sorted = stableSort(result, comparer);
         enumMemberCache.set(enumObject, sorted);
         return sorted;
     }