Use proper @types for markdown-to-jsx #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bk3c You could probably also remove it in |
|
@jaredcwhite good catch; done. See also mdx-js/mdx#811 -- it looks like they have types in mdx-js now, so we might be able to clean up some more of that. |
|
I'm not sure we'll be using MDX much longer…seems we're gradually shifting everything towards storing Markdown content elsewhere and parsing it on the fly with the m2jsx package. Anyway, LGTM |
jaredcwhite
approved these changes
Sep 2, 2020
YazeedLoonat
added a commit
that referenced
this pull request
Nov 28, 2023
* fix: fix flaky test by configuring the thottler (#3305) * chore(release): version - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] - @bloom-housing/[email protected] * fix: use translated labels on the progress bar when at the choose language step (#3307) * fix: add main content id (#3299) * docs: update terminology (#3318) * chore: remove unused phone number and email fields from household members (#3320) * feat: move shared helper components * feat: resetting migrations (#3309) * feat: resetting migrations * fix: add custom translation as separate migration * fix: limit hmi table to min and max occupancy (#3321) --------- Co-authored-by: Liann Sun <[email protected]> Co-authored-by: github.context.workflow <[email protected]> Co-authored-by: Emily Jablonski <[email protected]> Co-authored-by: Liann Sun <[email protected]> Co-authored-by: Jared White <[email protected]> Co-authored-by: Yazeed Loonat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They finally landed a PR to fix @types/markdown-to-jsx, so I went ahead and switched over to it before we forgot. Unrelated, other than it's another minor build cleanup in ui-components, but I also enabled
removeDeprecatedGapUtilitiesfor tailwind, which is officially a 2.0 deprecation, but we're not using it currently and the warning message at startup/build was annoying.fixes #347