Skip to content

port(upstream): #3411 - sanitize Gemini function response keys - #539

Merged
bloodf merged 2 commits into
mainfrom
port/upstream-3411-gemini-response-keys
Aug 22, 2026
Merged

bloodf merged 2 commits into
mainfrom
port/upstream-3411-gemini-response-keys

Conversation

@bloodf

@bloodf bloodf commented Aug 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

Type

port(upstream) — the PR template has no port: checkbox. Conventional type is port, scope upstream.

  • feat:
  • fix:
  • refactor:
  • docs:
  • ci:
  • chore:

Scope

Upstream #3411: sanitize Gemini function response keys.
Head port/upstream-3411-gemini-response-keys @ 606b0531fc047bae5ece865bea0fbd6d9e0562d2. Base main.
Independent branch off main.
Dirty primary checkout untouched.

Production files:

  • open-sse/translator/formats/gemini.js
  • open-sse/translator/request/claude-to-gemini.js
  • open-sse/translator/request/openai-to-gemini.js

Test coverage

Focused specs:

  • tests/unit/gemini-tool-response-sanitization.test.js

SHA-pinned local gate (lint, check:docs, check:registry-index, test:ci, build, commitlint). tests/__baseline__/known-fails.txt unchanged. Revert-proofed: focused specs went red after swapping production files back to the parent, then green after restore.

Doc coverage

Inline JSDoc / module-header comments at the port site: open-sse/translator/formats/gemini.js, open-sse/translator/request/claude-to-gemini.js, open-sse/translator/request/openai-to-gemini.js.

Baseline impact

None.

Wire-format / migration concerns

None beyond this upstream change. Existing stored API keys, ~/.9router/, and X-Msh-Platform: 9router remain accepted.

Breaking changes

  • No
  • Yes — describe below:

Testing

  • What was tested: the focused specs above plus one Node 20 full test:ci at 606b0531fc047bae5ece865bea0fbd6d9e0562d2.
  • Commands run: /tmp/gate-branch-v2.sh port/upstream-3411-gemini-response-keys 606b0531fc047bae5ece865bea0fbd6d9e0562d2; npx commitlint --from=origin/main --to=606b0531fc047bae5ece865bea0fbd6d9e0562d2.
  • Evidence: GATE_PASS port/upstream-3411-gemini-response-keys 606b053

Checklist

  • Tests added or updated for behavioral changes
  • No new dependencies without explicit justification
  • Conventional commit used (port(upstream):)
  • CHANGELOG updated if this change is user-facing
  • No secrets, keys, credentials, or tokens committed

@bloodf
bloodf merged commit f576969 into main Aug 22, 2026
3 checks passed
@bloodf
bloodf deleted the port/upstream-3411-gemini-response-keys branch September 4, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant