Skip to content

port(omniroute): #6938 - align grok-build Responses tool-call shape (source #6937) - #280

Merged
bloodf merged 3 commits into
devfrom
port/omniroute-6938
Jul 16, 2026
Merged

bloodf merged 3 commits into
devfrom
port/omniroute-6938

Conversation

@bloodf

@bloodf bloodf commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Port

OmniRoute #6938 (source commit from #6937) — align grok-build Responses tool-call shape.

Change

open-sse/translator/response/openai-responses.js: align the Responses-API tool-call projection with grok-build's expected shape (source PR #6937 behavior). Adds tests/translator/port-6937-responses-toolcall-shape.test.js defending the observable contract.

Verification

  • Lint: PASS (exit 0, pinned Node 20.20.2)
  • Build: PASS (exit 0)
  • Local test:ci gate blocked environmentally: worktree better-sqlite3 native binary fails to self-register under pinned Node 20 (49× module load errors across unrelated DB/OAuth/quota suites) + load-induced STACK_TRACE_ERRORs. MergeOm7054 verified 3 suites fail collection on clean origin/dev baseline — pre-existing dev breakage, not this diff. Diff is 2 files (translator + its test), none of the failing suites touch it.
  • Doc artifact: test file + inline coverage of the ported behavior (per AGENTS §1).

Branch head 04731a49d7 (verified port SHA).

Existing PRs

No existing PR for OmniRoute #6938 (searched head:port/omniroute-6938).

Disclosure

Agent-generated port (kimi-k2.7 via Oh My Pi harness); source-examined against upstream diff.

@bloodf
bloodf force-pushed the port/omniroute-6938 branch from 04731a4 to 093c223 Compare July 16, 2026 03:28

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04731a49d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread open-sse/translator/response/openai-responses.js Outdated
Comment thread open-sse/translator/response/openai-responses.js
Comment thread open-sse/translator/response/openai-responses.js Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69687485d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread open-sse/translator/response/openai-responses.js Outdated
Comment thread open-sse/translator/response/openai-responses.js Outdated
CortexOS and others added 2 commits July 16, 2026 18:54
…source #6937)

Port the Responses tool-call shape alignment. Source diff is OmniRoute #6937 (plan/branch ID #6938 is the upstream-swapped reasoningEffort row). Adds status in_progress/completed on function_call and custom_tool_call items, offsets tool-call output_index past a preceding reasoning item, and streams apply_patch via custom_tool_call_input.* events. Preserves call id, name, arguments, ordering, and non-tool text. Registration already present in open-sse/translator/index.js; doc is inline module JSDoc.
@bloodf
bloodf force-pushed the port/omniroute-6938 branch from 6968748 to e370418 Compare July 16, 2026 18:55
@bloodf
bloodf merged commit 316ee5c into dev Jul 16, 2026
3 checks passed
@bloodf
bloodf deleted the port/omniroute-6938 branch July 17, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant