port(omniroute): #6938 - align grok-build Responses tool-call shape (source #6937) - #280
Conversation
04731a4 to
093c223
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04731a49d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
093c223 to
6968748
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69687485d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…source #6937) Port the Responses tool-call shape alignment. Source diff is OmniRoute #6937 (plan/branch ID #6938 is the upstream-swapped reasoningEffort row). Adds status in_progress/completed on function_call and custom_tool_call items, offsets tool-call output_index past a preceding reasoning item, and streams apply_patch via custom_tool_call_input.* events. Preserves call id, name, arguments, ordering, and non-tool text. Registration already present in open-sse/translator/index.js; doc is inline module JSDoc.
…ic output indexes
6968748 to
e370418
Compare
Port
OmniRoute #6938 (source commit from #6937) — align grok-build Responses tool-call shape.
Change
open-sse/translator/response/openai-responses.js: align the Responses-API tool-call projection with grok-build's expected shape (source PR #6937 behavior). Addstests/translator/port-6937-responses-toolcall-shape.test.jsdefending the observable contract.Verification
test:cigate blocked environmentally: worktreebetter-sqlite3native binary fails to self-register under pinned Node 20 (49× module load errors across unrelated DB/OAuth/quota suites) + load-induced STACK_TRACE_ERRORs. MergeOm7054 verified 3 suites fail collection on cleanorigin/devbaseline — pre-existing dev breakage, not this diff. Diff is 2 files (translator + its test), none of the failing suites touch it.Branch head
04731a49d7(verified port SHA).Existing PRs
No existing PR for OmniRoute #6938 (searched
head:port/omniroute-6938).Disclosure
Agent-generated port (kimi-k2.7 via Oh My Pi harness); source-examined against upstream diff.