port(upstream): #2526 - hide disabled provider connections in combo picker - #273
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63a50d608f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bloodf
pushed a commit
that referenced
this pull request
Jul 16, 2026
…icker Codex P2 on PR #273: providerIdsToShow unconditionally unioned providerNodes ids, re-adding custom compatible-provider nodes whose connections are all disabled. connection.provider === node id, so activeConnectionIds already carries exactly the active nodes; drop the bypass.
bloodf
force-pushed
the
port/upstream-2526
branch
from
July 16, 2026 03:26
63a50d6 to
a638e15
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a638e15f9d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bloodf
pushed a commit
that referenced
this pull request
Jul 16, 2026
…icker Codex P2 on PR #273: providerIdsToShow unconditionally unioned providerNodes ids, re-adding custom compatible-provider nodes whose connections are all disabled. connection.provider === node id, so activeConnectionIds already carries exactly the active nodes; drop the bypass.
bloodf
pushed a commit
that referenced
this pull request
Jul 16, 2026
Codex P2 on PR #273: media-providers/combo/[id] passed raw /api/providers connections (including isActive === false) to ModelSelectModal. Apply filterActiveConnections at the fetch boundary so disabled media providers are hidden and cannot be saved into combos that fail at runtime.
bloodf
force-pushed
the
port/upstream-2526
branch
from
July 16, 2026 03:54
a638e15 to
a7e46b8
Compare
bloodf
pushed a commit
that referenced
this pull request
Jul 16, 2026
…icker Codex P2 on PR #273: providerIdsToShow unconditionally unioned providerNodes ids, re-adding custom compatible-provider nodes whose connections are all disabled. connection.provider === node id, so activeConnectionIds already carries exactly the active nodes; drop the bypass.
bloodf
pushed a commit
that referenced
this pull request
Jul 16, 2026
Codex P2 on PR #273: media-providers/combo/[id] passed raw /api/providers connections (including isActive === false) to ModelSelectModal. Apply filterActiveConnections at the fetch boundary so disabled media providers are hidden and cannot be saved into combos that fail at runtime.
bloodf
force-pushed
the
port/upstream-2526
branch
from
July 16, 2026 04:11
a7e46b8 to
2fbfafb
Compare
added 3 commits
July 16, 2026 04:40
…icker Codex P2 on PR #273: providerIdsToShow unconditionally unioned providerNodes ids, re-adding custom compatible-provider nodes whose connections are all disabled. connection.provider === node id, so activeConnectionIds already carries exactly the active nodes; drop the bypass.
Codex P2 on PR #273: media-providers/combo/[id] passed raw /api/providers connections (including isActive === false) to ModelSelectModal. Apply filterActiveConnections at the fetch boundary so disabled media providers are hidden and cannot be saved into combos that fail at runtime.
bloodf
force-pushed
the
port/upstream-2526
branch
from
July 16, 2026 04:44
2fbfafb to
14f6b96
Compare
7 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filterActiveConnections()helper insrc/shared/utils/connectionStatus.js(hides onlyisActive === false; legacy rows without the flag and no-auth connections stay visible), applied at the combo-page fetch site insrc/app/(dashboard)/dashboard/combos/page.js. Addstests/unit/connection-status.test.js(6 cases) anddocs/ports/upstream-2526.md.Type
fix:— bug fix (port of upstream fix; commit typeportper repo commitlint)Breaking changes
Testing
test:cisuite via.omc/gate.shunder pinned Node 20.20.2.npm run lint(0 errors),npm run build(success),bash .omc/gate.sh .omc/wt-port-up-2526.Checklist
port(upstream):— registered commitlint type)docs/ports/upstream-2526.mdper port-plan doc-artifact rule