port(omniroute): #6499 - prevent silent overwrite of existing API-key connections on edit - #269
Merged
Merged
Conversation
bloodf
force-pushed
the
port/omniroute-6499
branch
from
July 16, 2026 03:49
b654486 to
998f74d
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 998f74d654
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bloodf
force-pushed
the
port/omniroute-6499
branch
from
July 16, 2026 05:30
998f74d to
a048f8e
Compare
… connections on edit
… closed-to-open transition (#269) Previously only the connection name was reset when reopening the add-key modal, leaving stale API keys, Azure endpoint/deployment, account IDs, regions, and Ollama host values intact. This allowed a duplicate connection using the previous secret to be saved. - Add createAddApiKeyModalInitialState to apiKeyConnectionName.js to produce a fresh name, empty API key, and provider-specific defaults. - Replace inline useState defaults in AddApiKeyModal with the helper and reset all state slices on closed->open. - Add regression test asserting the fresh default state clears secrets and provider fields. - Update docs/providers/omniroute-open-provider-catalog.md to note the reopen-clears behavior. Closes Codex P2 thread on AddApiKeyModal.js:67.
bloodf
force-pushed
the
port/omniroute-6499
branch
from
July 16, 2026 18:09
a048f8e to
0dfed55
Compare
7 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Port of OmniRoute PR #6499 (diegosouzapw/OmniRoute): editing a provider connection no longer silently overwrites an existing API-key connection on name collision.
Changes
src/app/api/providers/route.js— collision check before update; 409 on duplicate API-key connectionsrc/lib/db/repos/connectionsRepo.js— collision detection helperdashboard/providers/[id]/page.js+AddApiKeyModal.js— surface the collision error instead of overwritingtests/unit/api-key-connection-collision-6499.test.js(new),api-key-connection-name.test.jsupdatedSource
Upstream: diegosouzapw/OmniRoute#6499
Ported from TypeScript to durindoor JS.
Disclosure
Agent-generated port (kimi-k2.7, Oh My Pi harness), executed under the approved upstream-PR-import plan.