[mdx-plugin-detect-imports] generate proper AST #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generate the proper AST + estree-util-visit to offset all nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we were high-jacking the
Literalnode to be able to pass down a piece of code that wasn't a literal but a line of code.So the AST in the end was generating some working piece of JS, but the AST was wrong (and it could break other AST-based plugins)
As I also start to use
estree-util-visitto offset the nodes, I had to move to full ESM, and I used aimport()in a .cjs file for backward compatibility.This makes so that the plugin becomes async and cannot be used anymore with
compileSync, only the asynccompile.