Make websocket optional for realtime fetcher #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Pull Request Test Coverage Report for Build 1b534c0a-b9b6-4447-a718-9ee238af2a7a
💛 - Coveralls |
vbaranov
approved these changes
Apr 18, 2019
saneery
approved these changes
Apr 18, 2019
ayrat555
approved these changes
Apr 18, 2019
Realtime fetcher already uses both websocket and JSONRPC polling for more reliable new block fetching. Though, if no websocket was available, the realtime fetcher wouldn't start, and no new blocks arrived at all. As we already have a polling fallback, we now make websocket optional. This will also help with supporting nodes without websocket API. To disable websocket API, pass `nil` in `subscribe_named_arguments.transport`.
goodsoft
force-pushed
the
gs-optional-websocket
branch
from
460f2eb
to
71dd5a7
Compare
gabitoesmiapodo
added a commit
that referenced
this pull request
Apr 18, 2019
* master: Make websocket optional for realtime fetcher (#1778) check assigns add CHANGELOG entry finish erc20 info fix eslint add CHANGELOG entry add only blocks path optionally show token transfer info add timestamp to block overview fix CHANGELOG entry fix first block parameter Update CHANGELOG CHange twitter acc link to official Blockscout acc twitter # Conflicts: # CHANGELOG.md # apps/block_scout_web/lib/block_scout_web/templates/layout/_footer.html.eex # apps/block_scout_web/lib/block_scout_web/templates/transaction/overview.html.eex # apps/block_scout_web/priv/gettext/default.pot # apps/block_scout_web/priv/gettext/en/LC_MESSAGES/default.po
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realtime fetcher already uses both websocket and JSONRPC polling for more reliable new block fetching.
Though, if no websocket was available, the realtime fetcher wouldn't start, and no new blocks arrived at all.
As we already have a polling fallback, we now make websocket optional.
This will also help with supporting nodes without websocket API.
To disable websocket API, pass
nilinsubscribe_named_arguments.transport.Checklist for your PR
CHANGELOG.mdwith this PR