Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow valid sql types to be used by Columns and Values #63

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

taronish-stytch
Copy link
Contributor

Due to the feature change that allowed nested structs to be passed (#60), two types of data fields were no longer included by calls to Columns and Values that we use:

  1. time.Time values
  2. structs implementing the driver.Valuer interface

I believe both of these should skip further recursion and be recognized as valid types to be used with this library.

Happy to talk through any of it, please let me know if you have any feedback. Thanks!

@blockloop
Copy link
Owner

blockloop commented Aug 4, 2023

Hey sorry I've been on vacation all week. Once CI passes I'll merge. Thanks for the PR!

@blockloop
Copy link
Owner

@taronish-stytch looks like you have a lint issue. I also removed the manual approval process from PR tests. Once you fix the lint issues I'll merge.

@coveralls
Copy link

Coverage Status

coverage: 99.617% (+0.8%) from 98.8% when pulling 892c834 on taronish-stytch:allow-sql-valid-types into 3e43b34 on blockloop:master.

@blockloop blockloop merged commit 27488e2 into blockloop:master Aug 4, 2023
@blockloop
Copy link
Owner

v2.2.1 Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants