fix: Allow valid sql types to be used by Columns and Values #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the feature change that allowed nested structs to be passed (#60), two types of data fields were no longer included by calls to
Columns
andValues
that we use:time.Time
valuesdriver.Valuer
interfaceI believe both of these should skip further recursion and be recognized as valid types to be used with this library.
time.Time
as valid column typedriver.Valuer
allows for implicit conversion to valid sql statementsHappy to talk through any of it, please let me know if you have any feedback. Thanks!