Add Aave

[sebastiantf]

Added Aave

Used the Contract Parser: https://contract-parser.d5.ai

Found two proxy addresses:

1. 0x398eC7346DcD622eDc5ae82352F02bE94C62d119 --> 0x6d252baea75459ed0077410613c5f6e51cab4750

2. 0x3dfd23A6c5E8BbcFc9581d2E864a68feb6a076d3 --> 0x5766067108e534419ce13f05899bc3e3f4344948

Also found 16 smart contracts with the same contract name AToken and the same events. Named them with suffixes _v2.json to _v16.json

Fixes #93

[sebastiantf]

@askeluv Please review

[askeluv]

Nice work @sebastiantf ! Just to double-check: you handled the proxy addresses as described here, correct?

Also I wonder if we should leave the ATokens out and instead see if there's some kind of factory event we could use to automatically detect them (similar to how we handle Uniswap pools, etc).

Will let @medvedev1088 do the final review before deployment.

[sebastiantf]

Yes @askeluv. I found that post from your original post on adding smart contracts to BigQuery and followed it.

[medvedev1088]

Also I wonder if we should leave the ATokens out and instead see if there's some kind of factory event we could use to automatically detect them (similar to how we handle Uniswap pools, etc).

I agree we should look deeper into it and find some factory method. Or combine multiple tables if they have the same interface. Having 13 version of the table will be difficult to maintain.

[askeluv]

I've asked for a factory in the Aave Discord: https://discordapp.com/channels/602826299974877205/636902500041228309/712685702285885502

One pragmatic alternative would be to keep 1 table, but list multiple contract addresses, similar to this:

ethereum-etl-airflow/dags/resources/stages/parse/table_definitions/aragon/DAOFactory_event_DeployDAO.json

Line 15 in 0ef4cb0

"contract_address": "SELECT * FROM UNNEST(['0x595b34c93aa2c2ba0a38daeede629a0dfbdcc559', '0xc29f0599df12eb4cbe1a34354c4bac6d944071d1', '0xb9da44c051c6cc9e04b7e0f95e95d69c6a6d8031'])",

[askeluv]

@sebastiantf would you mind doing the following:

1. Delete the "duplicates" of aToken contracts, and just keep 1 version for each event.
2. Replace the contract_address field similarly to what we've done here, where the list of addresses should be every aToken (16 in total?):

   ethereum-etl-airflow/dags/resources/stages/parse/table_definitions/aragon/DAOFactory_event_DeployDAO.json

   Line 15 in 0ef4cb0

   "contract_address": "SELECT * FROM UNNEST(['0x595b34c93aa2c2ba0a38daeede629a0dfbdcc559', '0xc29f0599df12eb4cbe1a34354c4bac6d944071d1', '0xb9da44c051c6cc9e04b7e0f95e95d69c6a6d8031'])",

I will add another $20 as tip for your trouble! Hope you don't mind.

[sebastiantf]

I can do that @askeluv. I shall look into it now.

[sebastiantf]

@askeluv Just to make sure, there are 9 events that have 16 duplicates. I have to modify the contract_address field of the first version of each of those 9 events' json to include the 16 addresses.
Is that correct?

[sebastiantf]

@askeluv I have made the changes. Please review.

[askeluv]

Great stuff, LGTM. Will let @medvedev1088 make the final review.

[medvedev1088]

LGTM.

[askeluv]

Paid out the bounty plus $20 tip as promised @sebastiantf - great work! Thanks

[sebastiantf]

Thanks @askeluv! Looking forward for more opportunities to work with you.