fix(google): use parametersJsonSchema for full JSON Schema support #6555
+81
−329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google's Schema spec for 'parameters' does not support $ref/$defs in tool definitions. Gemini 3 enforced stricter validation recently, causing silent failures. Switch to 'parametersJsonSchema' which supports full JSON Schema including $ref and $defs. This removes the need for process_map schema filtering. Removes technical debt (custom schema sanitizers), and fixes a functional regression with newer Gemini models. Signed-off-by: rabi <ramishra@redhat.com>
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Google's Schema spec for 'parameters' does not support $ref/$defs in tool definitions. Gemini 3 enforced stricter validation recently, causing silent failures.
Switch to 'parametersJsonSchema' which supports full JSON Schema including $ref and $defs. This removes the need for process_map schema filtering.
Removes technical debt (custom schema sanitizers), and fixes a functional regression with newer Gemini models.
Type of Change
AI Assistance
Testing
Tested with gemini models that were failing silently since yesterday.