-
Notifications
You must be signed in to change notification settings - Fork 2.4k
chore: upgrade rmcp #6516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade rmcp #6516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the rmcp library from version 0.12.0 to 0.13.0, introducing two new optional fields that must be initialized in the codebase: task in CallToolRequestParam and tasks in ServerCapabilities.
Changes:
- Updated
rmcpdependency from 0.12.0 to 0.13.0 in Cargo.toml - Added
task: Noneto allCallToolRequestParamstruct instantiations across provider formats and agent code - Added
tasks: Noneto allServerCapabilitiesstruct instantiations in extension implementations
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Bumps rmcp dependency from 0.12.0 to 0.13.0 |
| Cargo.lock | Updates rmcp and rmcp-macros versions with new dependencies |
| crates/goose/src/providers/venice.rs | Adds task field to CallToolRequestParam |
| crates/goose/src/providers/toolshim.rs | Adds task field to CallToolRequestParam |
| crates/goose/src/providers/formats/snowflake.rs | Adds task field to three CallToolRequestParam instances |
| crates/goose/src/providers/formats/openai_responses.rs | Adds task field to four CallToolRequestParam instances |
| crates/goose/src/providers/formats/openai.rs | Adds task field to two CallToolRequestParam instances |
| crates/goose/src/providers/formats/google.rs | Adds task field to CallToolRequestParam |
| crates/goose/src/providers/formats/databricks.rs | Adds task field to CallToolRequestParam |
| crates/goose/src/providers/formats/bedrock.rs | Adds task field to CallToolRequestParam |
| crates/goose/src/providers/formats/anthropic.rs | Adds task field to two CallToolRequestParam instances |
| crates/goose/src/conversation/tool_result_serde.rs | Adds task field to CallToolRequestParam |
| crates/goose/src/agents/todo_extension.rs | Adds tasks field to ServerCapabilities |
| crates/goose/src/agents/skills_extension.rs | Adds tasks field to ServerCapabilities |
| crates/goose/src/agents/mcp_client.rs | Adds task field to CallToolRequestParam |
| crates/goose/src/agents/extension_manager_extension.rs | Adds tasks field to ServerCapabilities |
| crates/goose/src/agents/code_execution_extension.rs | Adds tasks field to ServerCapabilities and task field to CallToolRequestParam |
| crates/goose/src/agents/chatrecall_extension.rs | Adds tasks field to ServerCapabilities |
| crates/goose-server/src/routes/agent.rs | Adds task field to CallToolRequestParam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think there are a few more places to add the new struct field.
0e3c121 to
9c4c4f2
Compare
* 'main' of github.com:block/goose: (28 commits) chore(deps): bump aiohttp from 3.13.0 to 3.13.3 in /scripts/provider-error-proxy (#6539) chore(deps): bump brotli from 1.1.0 to 1.2.0 in /scripts/provider-error-proxy (#6538) docs: temp correction for agent directory (#6544) chore: upgrade rmcp (#6516) docs: clarify directory in /documentation readme (#6541) Release 1.20.0 Standalone mcp apps (#6458) don't add escaping to the command field (#6519) Fix popular topics not starting chat when clicked (#6508) fix[desktop]: deeplink ui repeat on refresh (#6469) fixed test compilation on main branch (#6512) fix: correctly parse extension name from tool call for MCP apps (#6482) fixed 0 token in openrouter steaming (#6493) feat(goose-acp): enable parallel sessions with isolated agent state (#6392) copilot instruction to flag prelease docs (#6504) docs: acp mcp support (#6491) feat: add flatpak support for linux (#6387) fix(code_execution): serialize record_result output as JSON (#6495) perf(google): avoid accumulating thoughtSignatures across conversation history (#6462) fix(openai): make tool_call arguments optional and fix silent stream termination (#6309) ...
A relatively straightforward upgrade to the new RMCP. This will close out #6144 and perhaps more