Skip to content

Conversation

@Yorisoft
Copy link
Contributor

@Yorisoft Yorisoft commented Jan 12, 2026

Summary

Fixes accessibility issues in the ExtensionItem component where the entire card was clickable, causing accidental toggles and poor accessibility.

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

  • Removed onClick handler from Card component
  • Removed hover:cursor-pointer and hover:shadow-default from Card (no longer clickable)
  • Removed e.stopPropagation() from CardAction (no longer needed)
  • Added aria-label attributes to the Settings button and Switch for screen reader support

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

Manual testing - observed expected changes.

  • Verified clicking on card area no longer toggles extension
  • Verified Switch toggle still works correctly
  • Verified Settings button still works correctly
  • Verified keyboard navigation works (Tab to focus, Enter/Space to activate)

Related Issues

Relates to: fixes #6311

Screenshots/Demos (for UX changes)

Before:

531284767-575c1aad-1117-40c1-88b4-c11f192605b1

After:

Screencast_20260112_004007.mp4

Signed-off-by: Yelsin Sepulveda <yelsinsepulveda@gmail.com>
Copy link
Collaborator

@lifeizhou-ap lifeizhou-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution to fixing this bug! Looks good!

There's a small change needed in the inline comment below before we can merge.

Signed-off-by: Yelsin Sepulveda <yelsinsepulveda@gmail.com>
@lifeizhou-ap lifeizhou-ap merged commit 19d3ead into block:main Jan 12, 2026
18 checks passed
zanesq added a commit that referenced this pull request Jan 12, 2026
…ased

* 'main' of github.com:block/goose:
  chore: break up process agent response (#6348)
  More 3.7 removal (#6414)
  CLI show extension errors (#6398)
  fix[desktop]: Improve UX for ExtensionItem component (#6443)
  update[doc]: Add tip for GitHub Copilot Provider (#6441)
  Avoid using cliclack.confirm in non-interactive session (#6412)
  docs: claude prompt caching note (#6429)
  Restore task completion notification (#6427)
  docs: stream-json and auth-token cli options (#6426)
fbalicchia pushed a commit to fbalicchia/goose that referenced this pull request Jan 13, 2026
Signed-off-by: Yelsin Sepulveda <yelsinsepulveda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension card should not be clickable: a11y issue and causes accidental toggles

2 participants