Skip to content

Conversation

@r0x0d
Copy link
Contributor

@r0x0d r0x0d commented Jan 7, 2026

Summary

Some dependencies were not being used across the workspace. This patch removes them in the effort to reduce the packaging dependency graph.

Type of Change

  • Feature
  • Bug fix
  • Refactor / Code quality
  • Performance improvement
  • Documentation
  • Tests
  • Security fix
  • Build / Release
  • Other (specify below)

AI Assistance

  • This PR was created or reviewed with AI assistance

Testing

I have run both cargo build and cargo test locally.

Related Issues

Relates to #5716
Discussion: LINK (if any)

Screenshots/Demos (for UX changes)

Before:

After:

@r0x0d
Copy link
Contributor Author

r0x0d commented Jan 7, 2026

I have run an analysis using cursor and found out that the following dependencies does not have any code related to them. Maybe I'm missing something here, but the tests ran successfully locally.

@r0x0d r0x0d force-pushed the remove-unused-dependencies branch from bb94bb1 to ca82030 Compare January 7, 2026 21:07
Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you look this over and make sure that we keep dev-dependencies for now and anything that is platform specific.


[dev-dependencies]
tower = "0.5"
async-trait = "0.1.89"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@r0x0d
Copy link
Contributor Author

r0x0d commented Jan 8, 2026

can you look this over and make sure that we keep dev-dependencies for now and anything that is platform specific.

For sure! I will take care of this later tonight. Thanks!

@r0x0d r0x0d force-pushed the remove-unused-dependencies branch from ca82030 to f6d285a Compare January 10, 2026 00:07
Some dependencies were not being used across the workspace. This patch
removes them in the effort to reduce the packaging dependency graph.

Signed-off-by: Rodolfo Olivieri <rodolfo.olivieri3@gmail.com>
@DOsinga DOsinga merged commit 0be3ec1 into block:main Jan 12, 2026
18 checks passed
@r0x0d r0x0d deleted the remove-unused-dependencies branch January 12, 2026 17:51
fbalicchia pushed a commit to fbalicchia/goose that referenced this pull request Jan 13, 2026
Signed-off-by: Rodolfo Olivieri <rodolfo.olivieri3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants