fix: handle toolnames without underscores #6318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Dunn <[email protected]>
kdunn926
force-pushed
the
bugfix-tool-name
branch
from
140607b to
4d5261d
Compare
michaelneale
reviewed
Jan 2, 2026
| return message.params as Progress; | ||
| }; | ||
|
|
||
| // Helper function to extract toolcall name |
Collaborator
There was a problem hiding this comment.
can drop this comment I think
Collaborator
|
oh very nice! it REALLY bugged me how this happened some times... testing it out now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve handling for tool calls without a
__present in the name (see name truncation issue in the screenshot).Type of Change
AI Assistance
Testing
Manual testing
Screenshot