Skip to content

fix: support global .gooseignore and negation patterns #6157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamadeo merged 9 commits into from
Jan 14, 2026
Merged

fix: support global .gooseignore and negation patterns #6157

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
162f595
fix: support global .gooseignore and negation patterns
leocavalcante Dec 17, 2025
f3cd87b
fix: apply cargo fmt formatting
leocavalcante Dec 17, 2025
2628315
fix: isolate test_local_gooseignore_negation_overrides_defaults from …
leocavalcante Dec 17, 2025
ccae925
fix: address PR review comments for gooseignore implementation
leocavalcante Dec 22, 2025
dd08652
fix: simplify build_ignore_patterns and mark test as unix-only
leocavalcante Dec 22, 2025
077c6c9
fix: use etcetera to get correct config path in test
leocavalcante Dec 22, 2025
b7f4df1
fix: remove comments from build_ignore_patterns function
leocavalcante Dec 23, 2025
4f249c5
fix: only apply default ignore patterns when no gooseignore files exist
leocavalcante Dec 23, 2025
0840124
fix: remove complex gooseignore test
leocavalcante Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions crates/goose-mcp/src/developer/rmcp_developer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
use anyhow::anyhow;
use base64::Engine;
use etcetera::AppStrategy;
use ignore::gitignore::{Gitignore, GitignoreBuilder};
use include_dir::{include_dir, Dir};
use indoc::{formatdoc, indoc};
Expand Down Expand Up @@ -1284,14 +1285,26 @@ impl DeveloperServer {
fn build_ignore_patterns(cwd: &PathBuf) -> Gitignore {
let mut builder = GitignoreBuilder::new(cwd);
let local_ignore_path = cwd.join(".gooseignore");
let mut has_ignore_file = false;

if local_ignore_path.is_file() {
let _ = builder.add(local_ignore_path);
has_ignore_file = true;
let global_ignore_path = etcetera::choose_app_strategy(crate::APP_STRATEGY.clone())
.map(|strategy| strategy.config_dir().join(".gooseignore"))
.ok();

let has_local_ignore = local_ignore_path.is_file();
let has_global_ignore = global_ignore_path
.as_ref()
.map(|p| p.is_file())
.unwrap_or(false);

if has_global_ignore {
let _ = builder.add(global_ignore_path.as_ref().unwrap());
}

if has_local_ignore {
let _ = builder.add(&local_ignore_path);
}

if !has_ignore_file {
if !has_local_ignore && !has_global_ignore {
let _ = builder.add_line(None, "**/.env");
let _ = builder.add_line(None, "**/.env.*");
let _ = builder.add_line(None, "**/secrets.*");
Expand Down