Skip to content

fix : opening a session to view it modifies session history order in desktop #6156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abhijay007 merged 1 commit into from
Dec 23, 2025
Merged

fix : opening a session to view it modifies session history order in desktop #6156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/goose-server/src/routes/agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ async fn resume_agent(
})?;

agent
.update_provider(provider, &payload.session_id)
.load_provider(provider)
.await
.map_err(|e| ErrorResponse {
message: format!("Could not configure agent: {}", e),
Expand Down
8 changes: 8 additions & 0 deletions crates/goose/src/agents/agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,6 +1326,14 @@ impl Agent {
.context("Failed to persist provider config to session")
}

pub async fn load_provider(&self, provider: Arc<dyn Provider>) -> Result<()> {
let mut current_provider = self.provider.lock().await;
*current_provider = Some(provider.clone());

self.update_router_tool_selector(Some(provider.clone()), None)
Copy link
Collaborator

@michaelneale michaelneale Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odd that this is needed?

.await
}

pub async fn update_router_tool_selector(
&self,
provider: Option<Arc<dyn Provider>>,
Expand Down