Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/goose/src/agents/agent.rs
Original file line number Diff line number Diff line change
Expand Up @@ -999,6 +999,7 @@ impl Agent {
let conversation_with_moim = super::moim::inject_moim(
conversation.clone(),
&self.extension_manager,
&working_dir,
).await;

let mut stream = Self::stream_response_from_provider(
Expand Down
8 changes: 6 additions & 2 deletions crates/goose/src/agents/extension_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1223,9 +1223,13 @@ impl ExtensionManager {
.map(|ext| ext.get_client())
}

pub async fn collect_moim(&self) -> Option<String> {
pub async fn collect_moim(&self, working_dir: &std::path::Path) -> Option<String> {
let timestamp = chrono::Local::now().format("%Y-%m-%d %H:%M:%S").to_string();
let mut content = format!("<info-msg>\nDatetime: {}\n", timestamp);
let mut content = format!(
"<info-msg>\nDatetime: {}\nWorking directory: {}\n",
timestamp,
working_dir.display()
);

let extensions = self.extensions.lock().await;
for (name, extension) in extensions.iter() {
Expand Down
16 changes: 12 additions & 4 deletions crates/goose/src/agents/moim.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use crate::agents::extension_manager::ExtensionManager;
use crate::conversation::message::Message;
use crate::conversation::{fix_conversation, Conversation};
use rmcp::model::Role;
use std::path::Path;

// Test-only utility. Do not use in production code. No `test` directive due to call outside crate.
thread_local! {
Expand All @@ -11,12 +12,13 @@ thread_local! {
pub async fn inject_moim(
conversation: Conversation,
extension_manager: &ExtensionManager,
working_dir: &Path,
) -> Conversation {
if SKIP.with(|f| f.get()) {
return conversation;
}

if let Some(moim) = extension_manager.collect_moim().await {
if let Some(moim) = extension_manager.collect_moim(working_dir).await {
let mut messages = conversation.messages().clone();
let idx = messages
.iter()
Expand Down Expand Up @@ -45,17 +47,19 @@ pub async fn inject_moim(
mod tests {
use super::*;
use rmcp::model::CallToolRequestParam;
use std::path::PathBuf;

#[tokio::test]
async fn test_moim_injection_before_assistant() {
let em = ExtensionManager::new_without_provider();
let working_dir = PathBuf::from("/test/dir");

let conv = Conversation::new_unvalidated(vec![
Message::user().with_text("Hello"),
Message::assistant().with_text("Hi"),
Message::user().with_text("Bye"),
]);
let result = inject_moim(conv, &em).await;
let result = inject_moim(conv, &em, &working_dir).await;
let msgs = result.messages();

assert_eq!(msgs.len(), 3);
Expand All @@ -70,14 +74,16 @@ mod tests {
.join("");
assert!(merged_content.contains("Hello"));
assert!(merged_content.contains("<info-msg>"));
assert!(merged_content.contains("Working directory: /test/dir"));
}

#[tokio::test]
async fn test_moim_injection_no_assistant() {
let em = ExtensionManager::new_without_provider();
let working_dir = PathBuf::from("/test/dir");

let conv = Conversation::new_unvalidated(vec![Message::user().with_text("Hello")]);
let result = inject_moim(conv, &em).await;
let result = inject_moim(conv, &em, &working_dir).await;

assert_eq!(result.messages().len(), 1);

Expand All @@ -89,11 +95,13 @@ mod tests {
.join("");
assert!(merged_content.contains("Hello"));
assert!(merged_content.contains("<info-msg>"));
assert!(merged_content.contains("Working directory: /test/dir"));
}

#[tokio::test]
async fn test_moim_with_tool_calls() {
let em = ExtensionManager::new_without_provider();
let working_dir = PathBuf::from("/test/dir");

let conv = Conversation::new_unvalidated(vec![
Message::user().with_text("Search for something"),
Expand All @@ -119,7 +127,7 @@ mod tests {
Message::user().with_tool_response("search_2", Ok(vec![])),
]);

let result = inject_moim(conv, &em).await;
let result = inject_moim(conv, &em, &working_dir).await;
let msgs = result.messages();

assert_eq!(msgs.len(), 6);
Expand Down