Skip to content

Conversation

@Abhijay007
Copy link
Collaborator

@Abhijay007 Abhijay007 commented Dec 11, 2025

Closes: #3196

PR Description

This PR aims to implement a feature request to allow users to view complete tool output without truncation. It resolves issues where important information (such as Lightning invoice codes and GitHub device codes) was being cut off with "..." ellipsis.

Changes made :

  • Add /r command to toggle full tool output mode
  • Modify print_value() to respect toggle when truncating
  • Add ToggleFullToolOutput handler in session loop
  • Update help text with /r command in input.rs
  • Add unit tests for toggle functionality

Type of Change

  • Feature
  • Bug fix

AI Assistance

  • This PR was created or reviewed with AI assistance — used Goose for approach validation.

Testing

Added tests for the fix and also tested via CLI by running different commands.

Screenshots / Demos (for UX changes)

Before:
Screenshot 2025-12-11 195316

After:
Screenshot 2025-12-11 195358

Copilot AI review requested due to automatic review settings December 11, 2025 14:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a /r command to toggle full tool output display, addressing issue #3196 where important information (Lightning invoices, GitHub device codes) was being truncated with ellipsis. The feature allows users to see complete tool parameters without terminal width-based truncation.

Key Changes:

  • Added thread-local state management for the full output toggle
  • Modified truncation logic to respect the toggle setting
  • Integrated the toggle command into the session loop with user feedback

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crates/goose-cli/src/session/output.rs Added thread-local state for toggle, getter/setter functions, modified print_value() to check toggle before truncation, and added unit test
crates/goose-cli/src/session/mod.rs Added handler for ToggleFullToolOutput command with clear user feedback messages
crates/goose-cli/src/session/input.rs Added /r command parsing, updated help text with command description, and added unit test

Copy link
Collaborator

@alexhancock alexhancock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why /r?

@Abhijay007
Copy link
Collaborator Author

why /r?

The original issue mentioned Claude code uses ctrl+r so as we are using slash commands, I thought /r would be better

@Abhijay007 Abhijay007 force-pushed the feat/fullOutputToggel branch from 4ed579c to fc15551 Compare January 8, 2026 15:10
Copilot AI review requested due to automatic review settings January 8, 2026 15:10
@Abhijay007 Abhijay007 force-pushed the feat/fullOutputToggel branch from fc15551 to ca97b9e Compare January 8, 2026 15:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@alexhancock alexhancock merged commit 085f48a into block:main Jan 9, 2026
18 checks passed
zanesq added a commit that referenced this pull request Jan 9, 2026
…ased

* 'main' of github.com:block/goose:
  feat: add hotkey to toggle full tool output display (#6067)
fbalicchia pushed a commit to fbalicchia/goose that referenced this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a hotkey to show full tool output

3 participants