-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: add hotkey to toggle full tool output display #6067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a /r command to toggle full tool output display, addressing issue #3196 where important information (Lightning invoices, GitHub device codes) was being truncated with ellipsis. The feature allows users to see complete tool parameters without terminal width-based truncation.
Key Changes:
- Added thread-local state management for the full output toggle
- Modified truncation logic to respect the toggle setting
- Integrated the toggle command into the session loop with user feedback
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/goose-cli/src/session/output.rs | Added thread-local state for toggle, getter/setter functions, modified print_value() to check toggle before truncation, and added unit test |
| crates/goose-cli/src/session/mod.rs | Added handler for ToggleFullToolOutput command with clear user feedback messages |
| crates/goose-cli/src/session/input.rs | Added /r command parsing, updated help text with command description, and added unit test |
d770cf0 to
4ed579c
Compare
alexhancock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why /r?
The original issue mentioned Claude code uses ctrl+r so as we are using slash commands, I thought /r would be better |
4ed579c to
fc15551
Compare
Signed-off-by: Abhijay007 <[email protected]>
Signed-off-by: Abhijay007 <[email protected]>
fc15551 to
ca97b9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
…ased * 'main' of github.com:block/goose: feat: add hotkey to toggle full tool output display (#6067)
Signed-off-by: Abhijay007 <[email protected]>
Closes: #3196
PR Description
This PR aims to implement a feature request to allow users to view complete tool output without truncation. It resolves issues where important information (such as Lightning invoice codes and GitHub device codes) was being cut off with
"..."ellipsis.Changes made :
/rcommand to toggle full tool output modeprint_value()to respect toggle when truncatingToggleFullToolOutputhandler in session loop/rcommand ininput.rsType of Change
AI Assistance
Testing
Added tests for the fix and also tested via CLI by running different commands.
Screenshots / Demos (for UX changes)
Before:

After:
