Skip to content

fix: display shell output as static text instead of spinner #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexhancock merged 1 commit into from
Dec 16, 2025
Merged

fix: display shell output as static text instead of spinner #6041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions crates/goose-cli/src/session/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1085,8 +1085,12 @@ impl CliSession {
};
(formatted, subagent_id.map(str::to_string), notification_type.map(str::to_string))
} else if let Some(Value::String(output)) = o.get("output") {
// Fallback for other MCP notification types
(output.to_owned(), None, None)
// Extract type if present (e.g., "shell_output")
let notification_type = o.get("type")
.and_then(|v| v.as_str())
.map(str::to_string);

(output.to_owned(), None, notification_type)
} else if let Some(result) = format_task_execution_notification(data) {
result
} else {
Expand Down Expand Up @@ -1121,6 +1125,14 @@ impl CliSession {
print!("{}", formatted_message);
std::io::stdout().flush().unwrap();
}
} else if notification_type == "shell_output" {
// Hide spinner, print shell output, spinner will resume
if interactive {
let _ = progress_bars.hide();
}
if !is_json_mode {
println!("{}", formatted_message);
}
}
}
else if output::is_showing_thinking() {
Expand Down