Skip to content

fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 #5966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelneale merged 2 commits into from
Dec 17, 2025
Merged

fix(providers): fix for gemini-cli on windows to work around cmd's multiline prompt limitations #5911 #5966

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57ed0ad
fix(providers): fix for gemini-cli on windows to work around cmd's mu…
tko39 Dec 3, 2025
e61819f
fix(ci): code format to pass CI check
tko39 Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions crates/goose/src/providers/gemini_cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ use rmcp::model::Role;
use rmcp::model::Tool;

pub const GEMINI_CLI_DEFAULT_MODEL: &str = "gemini-2.5-pro";
pub const GEMINI_CLI_KNOWN_MODELS: &[&str] = &["gemini-2.5-pro"];
pub const GEMINI_CLI_KNOWN_MODELS: &[&str] = &[
"gemini-2.5-pro",
"gemini-2.5-flash",
"gemini-2.5-flash-lite",
];

pub const GEMINI_CLI_DOC_URL: &str = "https://ai.google.dev/gemini-api/docs";

Expand Down Expand Up @@ -98,7 +102,13 @@ impl GeminiCliProvider {
cmd.arg("-m").arg(&self.model.model_name);
}

cmd.arg("-p").arg(&full_prompt).arg("--yolo");
if cfg!(windows) {
let sanitized_prompt = full_prompt.replace("\r\n", "\\n").replace('\n', "\\n");

cmd.arg("-p").arg(&sanitized_prompt).arg("--yolo");
} else {
cmd.arg("-p").arg(&full_prompt).arg("--yolo");
}

cmd.stdout(Stdio::piped()).stderr(Stdio::piped());

Expand Down