fix(ui): prevent incorrect provider type suffix in update dialog #5908 #5909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base engine names (e.g., 'openai', 'anthropic') are persisted correctly in the backend configuration. However, `ProviderGrid.tsx` was appending a `_compatible` suffix to the engine key before passing it to `CustomProviderForm`. `CustomProviderForm` expects the raw base engine name to correctly map it to the dropdown selection. Receiving the suffixed version caused the lookup to fail, defaulting the provider type to "OpenAI Compatible" and subsequently overwriting the correct configuration on save. This fix removes the unnecessary suffix, ensuring the form receives the correct engine key. This change is isolated to the custom provider configuration flow in the UI. Signed-off-by: threebeanbags <[email protected]>
DOsinga
reviewed
Dec 5, 2025
|
|
||
| const initialData = editingProvider && { | ||
| engine: editingProvider.config.engine.toLowerCase() + '_compatible', | ||
| engine: editingProvider.config.engine.toLowerCase(), |
Collaborator
There was a problem hiding this comment.
nice. the lowercase probably doesn't hurt, but it feels like another possible gotcha
DOsinga
approved these changes
Dec 5, 2025
katzdave
added a commit
that referenced
this pull request
Dec 12, 2025
…nses-streaming * 'main' of github.com:block/goose: Fix community page mobile responsiveness and horizontal overflow (#6082) Tool reply meta (#6074) chore: avoid accidentally using native tls again (#6086) Update vars to be capitalised to be in line with other variables in config file (#6085) docs: restructure recipe reference (#5972) docs: configure custom providers (#6044) docs: Community All-Stars Spotlight November 2025, CodeTV Hackathon edition (#6070) fix: include file attachments in queued messages (#5961) fix(ui): prevent incorrect provider type suffix in update dialog #5908 (#5909) docs: mcp elicitation (#6060)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The base engine names (e.g., 'openai', 'anthropic') are persisted correctly in the backend configuration. However,
ProviderGrid.tsxwas appending a_compatiblesuffix to the engine key before passing it toCustomProviderForm.CustomProviderFormexpects the raw base engine name to correctly map it to the dropdown selection. Receiving the suffixed version caused the lookup to fail, defaulting the provider type to "OpenAI Compatible" and subsequently overwriting the correct configuration on save.This fix removes the unnecessary suffix, ensuring the form receives the correct engine key. This change is isolated to the custom provider configuration flow in the UI.
Type of Change
AI Assistance
Testing
Manual testing for following cases:
Automated testing:
Related Issues
Relates to #5908