Skip to content

scan recipe for security when saving recipe #5747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lifeizhou-ap merged 2 commits into from
Nov 17, 2025
Merged

scan recipe for security when saving recipe #5747

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5370c28
scan recipe for security when saving recipe
lifeizhou-ap Nov 14, 2025
506476c
update the message
lifeizhou-ap Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/goose-server/src/routes/recipe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,13 @@ async fn save_recipe(
) -> Result<Json<SaveRecipeResponse>, ErrorResponse> {
let Json(raw_json) = payload.map_err(json_rejection_to_error_response)?;
let request = deserialize_save_recipe_request(raw_json)?;
let has_security_warnings = request.recipe.check_for_security_warnings();
if has_security_warnings {
return Err(ErrorResponse {
message: "This recipe contains hidden characters that will be ignored for your safety, as they could be used for malicious purposes.".to_string(),
Copy link
Collaborator

@DOsinga DOsinga Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't it more the case that we are refusing the save this recipe? so say something like, this contains hidden characters, please remove before trying to save?

status: StatusCode::BAD_REQUEST,
});
}
ensure_recipe_valid(&request.recipe)?;

let file_path = match request.id.as_ref() {
Expand Down
Loading