use npx in just generate-openapi #5664
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the generate-openapi Justfile target by using npx openapi-ts directly instead of calling the npm run generate-api script, eliminating the need to install npm dependencies in release workflows.
- Replaces
npm run generate-apiwithnpx openapi-tsin thegenerate-openapitarget
| cargo run -p goose-server --bin generate_schema | ||
| @echo "Generating frontend API..." | ||
| cd ui/desktop && npm run generate-api | ||
| cd ui/desktop && npx openapi-ts |
There was a problem hiding this comment.
The openapi-ts command reads configuration from openapi-ts.config.ts which is in the ui/desktop directory. However, the CI workflow at .github/workflows/ci.yml:95 runs npm ci to install dependencies before calling just check-openapi-schema. This change breaks the workflow because npx will need to download @hey-api/openapi-ts on every run instead of using the installed version. Either keep using npm run generate-api (which requires npm ci first), or remove the npm ci step from the CI workflow if you want to rely on npx auto-downloading.
| cd ui/desktop && npx openapi-ts | |
| cd ui/desktop && npm run generate-api |
There was a problem hiding this comment.
Well this is obviously wrong because CI passed.
But also, npx will run from local node_modules first: https://docs.npmjs.com/cli/v7/commands/npx
Signed-off-by: Blair Allan <[email protected]>
rather than install all the tools in the release workflows