Skip to content

fix(extensions/desktop): only show env vars for stdio mcps #5430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexhancock merged 1 commit into from
Oct 29, 2025
Merged

fix(extensions/desktop): only show env vars for stdio mcps #5430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 33 additions & 33 deletions ui/desktop/src/components/settings/extensions/modal/ExtensionModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,6 @@ export default function ExtensionModal({
submitAttempted={submitAttempted}
/>

{/* Divider */}
<hr className="border-t border-borderSubtle" />

{/* Command */}
Expand All @@ -374,42 +373,43 @@ export default function ExtensionModal({
/>
</div>

{/* Divider */}
<hr className="border-t border-borderSubtle" />
{formData.type === 'stdio' && (
<>
<hr className="border-t border-borderSubtle" />

<div>
<EnvVarsSection
envVars={formData.envVars}
onAdd={handleAddEnvVar}
onRemove={handleRemoveEnvVar}
onChange={handleEnvVarChange}
submitAttempted={submitAttempted}
onPendingInputChange={setHasPendingEnvVars}
/>
</div>
</>
)}

{/* Environment Variables */}
<div>
<EnvVarsSection
envVars={formData.envVars}
onAdd={handleAddEnvVar}
onRemove={handleRemoveEnvVar}
onChange={handleEnvVarChange}
submitAttempted={submitAttempted}
onPendingInputChange={setHasPendingEnvVars}
/>
</div>
{formData.type === 'streamable_http' && (
<>
{/* Divider */}
<hr className="border-t border-borderSubtle" />

<div>
<HeadersSection
headers={formData.headers}
onAdd={handleAddHeader}
onRemove={handleRemoveHeader}
onChange={handleHeaderChange}
submitAttempted={submitAttempted}
onPendingInputChange={handlePendingHeaderChange}
/>
</div>
</>
)}
</div>
)}

{/* Request Headers - Only for streamable_http */}
{formData.type === 'streamable_http' && (
<>
{/* Divider */}
<hr className="border-t border-borderSubtle mb-4" />

<div className="mb-6">
<HeadersSection
headers={formData.headers}
onAdd={handleAddHeader}
onRemove={handleRemoveHeader}
onChange={handleHeaderChange}
submitAttempted={submitAttempted}
onPendingInputChange={handlePendingHeaderChange}
/>
</div>
</>
)}

<DialogFooter className="pt-2">
{showDeleteConfirmation ? (
<>
Expand Down