Fix bedrock tool call error response #5067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a tool call fails, bedrock expects that a response is returned back to the api regardless of the tool call result. Prior to this patch, bedrock would throw an exception that goose could not handle. This patch fixes this by returning a text content block with the error message instead of returning nothing. Signed-off-by: alexyao2015 <[email protected]>
alexyao2015
force-pushed
the
fix/bedrock-failed-toolcall
branch
from
09c3a57 to
514d5ef
Compare
jamadeo
approved these changes
Oct 21, 2025
katzdave
added a commit
that referenced
this pull request
Oct 21, 2025
* 'main' of github.com:block/goose: fix: include Windows GNU CLI artifact in releases (#5276) Fix bedrock tool call error response (#5067) fix: do not load active extensions when no extensions in the recipe (#5282) Fix pagination - fetch all open issues, not just first 100 Fix label case sensitivity - use lowercase labels Add GitHub Health Dashboard workflow (#5286) live testing script (#5263) escaping markdown fixing syntax Add GitHub Health Dashboard workflow Fix extension manager resource deadlock (#5066) add new prompt for memory extension (#4945) feat: Stable system prompt and tool ordering for more cache hits (#5192) Remove gtag analytics error (#5268)
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Oct 25, 2025
Signed-off-by: alexyao2015 <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Jack Amadeo <[email protected]> Signed-off-by: Blair Allan <[email protected]>
BlairAllan
pushed a commit
to BlairAllan/goose
that referenced
this pull request
Nov 29, 2025
Signed-off-by: alexyao2015 <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Jack Amadeo <[email protected]> Signed-off-by: Blair Allan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a tool call fails, bedrock expects that a response is returned back to the api regardless of the tool call result. Prior to this patch, bedrock would throw an exception that goose could not handle. This patch fixes this by returning a text content block with the error message instead of returning nothing.
Type of Change
Testing
This was tested manually and saw that bedrock no longer returned an error after this change.