Skip to content

Fix extension manager resource deadlock #5066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamadeo merged 1 commit into from
Oct 20, 2025
Merged

Fix extension manager resource deadlock #5066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions crates/goose/src/agents/extension_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,9 +705,13 @@ impl ExtensionManager {
// Loop through each extension and try to read the resource, don't raise an error if the resource is not found
// TODO: do we want to find if a provided uri is in multiple extensions?
// currently it will return the first match and skip any others
for extension_name in self.extensions.lock().await.keys() {

// Collect extension names first to avoid holding the lock during iteration
let extension_names: Vec<String> = self.extensions.lock().await.keys().cloned().collect();

for extension_name in extension_names {
let result = self
.read_resource_from_extension(uri, extension_name, cancellation_token.clone())
.read_resource_from_extension(uri, &extension_name, cancellation_token.clone())
.await;
match result {
Ok(result) => return Ok(result),
Expand Down
Loading