-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Art vandelay: Import & Export #5053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| (status = 200, description = "Session exported successfully", body = String), | ||
| (status = 401, description = "Unauthorized - Invalid or missing API key"), | ||
| (status = 404, description = "Session not found"), | ||
| (status = 500, description = "Internal server error") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these just add to the openapi, you don't need to enumerate them, but you can if you want to. (on our other endpoints, I don't think they're always telling the truth)
| .accumulated_output_tokens(import.accumulated_output_tokens) | ||
| .schedule_id(import.schedule_id) | ||
| .recipe(import.recipe) | ||
| .user_recipe_values(import.user_recipe_values), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider constructing the struct itself without the builder so any added new fields are caught at compile time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had that at first, but it becomes awkward since we still want to call create_session at this point so then we need to update only the other fields?
| throwOnError: true, | ||
| }); | ||
|
|
||
| const json = response.data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the below works but feels a bit like coaxing the electron renderer code into downloading the file. would there be a natural spot to do this rust-side as part of exportSession?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the cleaner API is for the server to return the contents of the exported file and let the download be handled by the browser; imagine the server runs on a different host - no suddenly that file appears in a different file system. or if we run this code on a browser and you have set up your browser to put the downloads somewhere else. the server wouldn't know about that
Co-authored-by: Douwe Osinga <[email protected]>
* origin/main: Art vandelay: Import & Export (#5053) docs: misc updates for extensions directory (#5035) updating recipe scanner workflows for detecting recipes from forked repos (#5056) feat(prompt-library): add Smart Meeting Assistant advanced prompt (#4998) (#5031) Allow auto focus and typing while chat is initializing (#5043) docs(blog): Add blog for running Goose in containerized envs (#5052)
* main: (170 commits) Applied server side call to parse and save recipe (#5022) feat(prompt-library): add Code Documentation Migrator intermediate prompt (#4996) (#5051) Add Messy Column Fixer recipe (#5062) Cleanup temp files (#5081) add openmetadata recipe (#5076) Fix Hacktoberfest Leaderboard (#5080) adding brand guidelines to AGENTS.md (#4887) Fix: Prevent cross-contamination of cache data across analysis modes for `analyze` tool (#5075) fix: remove circular reference (#5018) Introduced a new prompt for content amplification that integrates multi-step workflows using official Goose extensions. Closes Issue #4998 (#5050) Add hint for focus mode when used on file paths for `analyze` tool (#5069) fix: use dynamic port allocation for OAuth server (#5019) Art vandelay: Import & Export (#5053) docs: misc updates for extensions directory (#5035) updating recipe scanner workflows for detecting recipes from forked repos (#5056) feat(prompt-library): add Smart Meeting Assistant advanced prompt (#4998) (#5031) Allow auto focus and typing while chat is initializing (#5043) docs(blog): Add blog for running Goose in containerized envs (#5052) fix: Add WINDOWS_CODESIGN_CERTIFICATE to nightly workflow (#5037) Developer `analyze` tool improvement (#5030) ...
Make it possible to import and export sessions directly from the desktop