Feat: Added custom headers and toggle keyring CLI options #5017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlairAllan
force-pushed
the
feat/custom-headers-keyring-config
branch
2 times, most recently
from
ac9d599 to
564ff96
Compare
Contributor
|
Let us know when this is ready for review, or if you have questions! |
BlairAllan
force-pushed
the
feat/custom-headers-keyring-config
branch
from
564ff96 to
dffd0dd
Compare
BlairAllan
changed the title
DOsinga
approved these changes
Oct 21, 2025
iandouglas
previously requested changes
Oct 21, 2025
Contributor
|
here's how to fix the DCO check |
BlairAllan
force-pushed
the
feat/custom-headers-keyring-config
branch
3 times, most recently
from
b37fb67 to
cbee07e
Compare
Collaborator
|
sorry @BlairAllan for letting this linger - there was a merge conflict I tried to fix, but we changed the interface and I think I made it worse. can you have a look? |
BlairAllan
force-pushed
the
feat/custom-headers-keyring-config
branch
from
c93eead to
4d119b2
Compare
Collaborator
|
there's a linter error now @BlairAllan |
BlairAllan
force-pushed
the
feat/custom-headers-keyring-config
branch
7 times, most recently
from
edbfbe0 to
36d83b8
Compare
Signed-off-by: Blair Allan <Blairallan@icloud.com>
Signed-off-by: Blair Allan <Blairallan@icloud.com>
Signed-off-by: Blair Allan <Blairallan@icloud.com>
Signed-off-by: Blair Allan <Blairallan@icloud.com>
Signed-off-by: Blair Allan <Blairallan@icloud.com>
BlairAllan
force-pushed
the
feat/custom-headers-keyring-config
branch
from
36d83b8 to
a525296
Compare
Contributor
Author
This should all be fixed now |
zanesq
added a commit
that referenced
this pull request
Dec 1, 2025
* 'main' of github.com:block/goose: Feat: Added custom headers and toggle keyring CLI options (#5017) Feat/automatic update installation (#5345) fix: Added "Merged consecutive assistant messages" to the acceptable issues for moim injection check (#5933) fix: anthropic provider model fetching (#5932) [MCP-UI] add CSP for images to proxy HTML (#5931)
zanesq
added a commit
that referenced
this pull request
Dec 2, 2025
…0-5147 * 'main' of github.com:block/goose: (243 commits) chore: upgrade npm packages (#5951) feat: ActionRequired (#5897) feat(acp): support loading sessions in acp (#5942) docs: add videos to multi-model page (#5938) docs: promote planning guide (#5934) fix: use a lock to ensure only need to run tunnel just in case multiple go… (#5885) Feat: Added custom headers and toggle keyring CLI options (#5017) Feat/automatic update installation (#5345) fix: Added "Merged consecutive assistant messages" to the acceptable issues for moim injection check (#5933) fix: anthropic provider model fetching (#5932) [MCP-UI] add CSP for images to proxy HTML (#5931) fix: correct typo in blog post (AIMDOEL -> AIMODEL) (#5902) feat: @goose in terminal (native terminal support) (#5887) docs: adding AI-friendly features (#5918) Blog/advent of ai announcement (#5917) Extension selector behind ALPHA flag (#5892) blog: typo fixes (#5896) blog: fixing img url (#5895) blog: MCPs for Developers (#5884) docs: Extension Manager MCP (#5883) ... # Conflicts: # crates/goose-server/src/routes/config_management.rs # crates/goose/src/providers/mod.rs # ui/desktop/openapi.json # ui/desktop/src/api/sdk.gen.ts # ui/desktop/src/api/types.gen.ts # ui/desktop/src/components/ProgressiveMessageList.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for custom HTTP headers and a CLI option to toggle keyring storage. Updated docs to explain how to add these headers and provided an example.
Type of Change
Testing
and loaded correctly
Storage