Remove orphaned tool calls before compacting #4987
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
ehh also trying to merge some duplicated logic in perform_compaction + check_and_compact. |
- Add fix_conversation to handle agent_visible vs user_visible messages separately - Update fix_lead_trail to have more specific error message for trailing assistant messages - Add two new tests for handling pending tool requests in last assistant message - Conversation fixes now only apply to agent_visible messages, preserving non-visible ones
katzdave
force-pushed
the
dkatz/main-rm-orphaned-tool-calls
branch
from
f43501a to
24fe252
Compare
Collaborator
Author
|
replaced with: #5059 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove orphaned tool calls before compacting + run fix conversation
#4968 is the same thing but with session apis compatible with 1.9.1