Fix_conversation handles mismatching visibility on tool call requests/response #4966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katzdave
changed the title
DOsinga
reviewed
Oct 2, 2025
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
can you add a test to this that shows the situation of what we want to cover here?
| assert!(issues[0].contains("Removed orphaned tool request")); | ||
| assert!(issues[1].contains("Merged consecutive assistant messages")); | ||
| assert!(issues[0].contains("Merged consecutive assistant messages")); | ||
| assert!(issues[1].contains("Removed orphaned tool request")); |
Collaborator
Author
|
I don't really like this fix overall. Switching that order is part of why it works, but I can validate this works with a broken session file. I think we should go with #4968, but still testing it more |
Collaborator
|
ok, since this is obsolete now, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.