Revert "lowercase g in goose" #4874
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2032c70.
Contributor
|
angelahning
approved these changes
Sep 29, 2025
Collaborator
|
what build issues were you noticing @michaelneale? |
Collaborator
Author
|
@alexhancock oh this was an older attempted - took me a few hours but I was able to patch up main. The lowercase g removed some data which was needed by the tests and was failing, so added it back in, fixed openapi stuff etc - but if that didn't work, rolling back was an option (honestly the rename PR was broken so am not sure how it was merged, it shouldn't have been in that form) - but my aim was to get it clean before your work day so no one noticed! |
Collaborator
You did marvelously! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4832
seeing if this resolves the build (maybe some case insensitivity inconsistency)
we may need to do this, and then do a different change just with the casing of the doc site