refactor: move download_tokenizers.sh to a cargo build script
#476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salman1993
approved these changes
Dec 16, 2024
Contributor
salman1993
left a comment
salman1993
left a comment
There was a problem hiding this comment.
we can also remove download_tokenizer_files.py since its no longer being used
Contributor
Author
I wasn't sure about that one, but done! |
This simplifies the build to just `cargo build`. Also added a rust-toolchain.toml file so that `rustup` will Just Work™️.
Contributor
Author
|
Mmm I don't think that build failure is my fault? At least, I didn't touch the Desktop App workflow, only the release. |
Contributor
Author
|
Moved this to #490, on a branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the build to just
cargo build. Also added a rust-toolchain.toml file so thatrustupwill Just Work™️.