Fix debug UI connection to external goosed server #4675
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi! I opened #4669 yesterday with the patch. I don't care what PR is merged (the code is yours anyway, as I mentioned in the PR description 😄 ). If you prefer to close that one and merge this, would you mind incorporating here the other changes to the doc and the Justfile I added there? |
DOsinga
approved these changes
Sep 18, 2025
|
|
||
| const isReady = await checkServerStatus(); | ||
| if (!isReady) { | ||
| throw new Error(`External goosed server not accessible on port ${port}`); |
Collaborator
There was a problem hiding this comment.
instead of duplicating this code, we can jsut delete the isReady check since that happens after we call this function anyway
zanesq
approved these changes
Sep 18, 2025
Collaborator
Author
|
Closing this in favor of https://github.com/block/goose/pull/4669/files since it has the nice doc update and an identical bug fix #4669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The UI fails to connect when using an external goosed backend for debugging, timing out after 20 seconds even though the server is running.
Root Cause
The checkServerStatus() call happens before the API client is configured with authentication headers.
Solution
Configure the client with auth headers before checking status in connectToExternalBackend().
Testing
Start goosed: GOOSE_SERVER__SECRET_KEY=test GOOSE_PORT=3000 ./target/release/goosed agent
Connect UI: just debug-ui