Skip to content

Fast model falls back to regular #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katzdave merged 3 commits into from
Aug 28, 2025
Merged

Fast model falls back to regular #4375

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4dcfda
fast model fallback
katzdave Aug 27, 2025
d7d456f
rm noise
katzdave Aug 27, 2025
bb530ca
Clean up comments in base.rs
katzdave Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion crates/goose/src/providers/base.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,8 +348,27 @@ pub trait Provider: Send + Sync {
) -> Result<(Message, ProviderUsage), ProviderError> {
let model_config = self.get_model_config();
let fast_config = model_config.use_fast_model();
self.complete_with_model(&fast_config, system, messages, tools)

match self
.complete_with_model(&fast_config, system, messages, tools)
.await
{
Ok(result) => Ok(result),
Err(e) => {
if fast_config.model_name != model_config.model_name {
tracing::warn!(
"Fast model {} failed with error: {}. Falling back to regular model {}",
fast_config.model_name,
e,
model_config.model_name
);
self.complete_with_model(&model_config, system, messages, tools)
.await
} else {
Err(e)
}
}
}
}

/// Get the model config from the provider
Expand Down
Loading