Fix eleven labs audio transcription and added more logging #4358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DOsinga
approved these changes
Aug 27, 2025
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
There's a lot wrong with this code but that was already the case of course
| } | ||
|
|
||
| /// Send transcription request to OpenAI Whisper API | ||
| async fn send_openai_request( |
Collaborator
There was a problem hiding this comment.
It would be better if we would just move this to the openai provider class and then just instantiate the openai provider; that way it would use whatever the user had configured for openai (proxy etc). we'd still have to check whether it works of course, but it would be cleaner
Collaborator
Author
There was a problem hiding this comment.
yeah good call, will follow up with this to get this fix out sooner
| // Default settings - don't force OpenAI as default | ||
| loadedSettings = { | ||
| enabled: false, | ||
| provider: null, |
Collaborator
There was a problem hiding this comment.
this should come from settings of course
Collaborator
Author
There was a problem hiding this comment.
true, moved these to a shared settings constants area rather than hard coded
| .map(|_| true) | ||
| .unwrap_or(false) | ||
| }); | ||
| config.get("ELEVENLABS_API_KEY", false).is_ok() |
Collaborator
There was a problem hiding this comment.
what backwards compatibility is this?
Collaborator
Author
There was a problem hiding this comment.
I think it used to be stored in plain text in the config so its trying that first before secrets. Might be able to remove that now
ui/desktop/src/hooks/useWhisper.ts
Outdated
| let body: Record<string, string> = { | ||
| audio: base64Audio, | ||
| mime_type: 'audio/webm', | ||
| mime_type: audioBlob.type || 'audio/webm', |
Collaborator
There was a problem hiding this comment.
is audioBlob.type ever not set? if so shouldn't we just bail?
Collaborator
Author
There was a problem hiding this comment.
good call will change that 👍
…nscribing * 'main' of github.com:block/goose: update tetrate blog date to today (#4368) tetrate signup: blog/launch post (#4313) Implement graceful recipe error handling with filename display (#4363) docs: airgapped operation by bypassing hermit for desktop app (#4063) remove Ollama card from welcome screen (#4348) feat: initial implementation of extension malware check (#4272) Add Tetrate Agent Router Service to Provider Registry (#4354) Goose Simple Compact UX (#4202) Refactor Extensions Install Modal (#4328) fix: url path trailing slash for custom-providers (#4345) docs: update available and onboarding providers list (#4356)
zanesq
added a commit
that referenced
this pull request
Aug 27, 2025
katzdave
added a commit
that referenced
this pull request
Aug 27, 2025
* 'main' of github.com:block/goose: Fix eleven labs audio transcription and added more logging (#4358) feat: re-introduce session sharing (#4370) remove duplicate blog post (#4369) fix focus ring under form submits (#4332) Trigger docs deployment update tetrate blog date to today (#4368) tetrate signup: blog/launch post (#4313) Implement graceful recipe error handling with filename display (#4363) docs: airgapped operation by bypassing hermit for desktop app (#4063) remove Ollama card from welcome screen (#4348) feat: initial implementation of extension malware check (#4272) Add Tetrate Agent Router Service to Provider Registry (#4354) Goose Simple Compact UX (#4202)
michaelneale
added a commit
that referenced
this pull request
Aug 28, 2025
* main: (38 commits) feat: linux computer control for android (termux) (#3890) feat: Added scroll state support for chat-session-list navigation (#4360) docs: typo fix (#4376) blog: goose janitor (#4131) Fix eleven labs audio transcription and added more logging (#4358) feat: re-introduce session sharing (#4370) remove duplicate blog post (#4369) fix focus ring under form submits (#4332) Trigger docs deployment update tetrate blog date to today (#4368) tetrate signup: blog/launch post (#4313) Implement graceful recipe error handling with filename display (#4363) docs: airgapped operation by bypassing hermit for desktop app (#4063) remove Ollama card from welcome screen (#4348) feat: initial implementation of extension malware check (#4272) Add Tetrate Agent Router Service to Provider Registry (#4354) Goose Simple Compact UX (#4202) Refactor Extensions Install Modal (#4328) fix: url path trailing slash for custom-providers (#4345) docs: update available and onboarding providers list (#4356) ...
dorien-koelemeijer
pushed a commit
to dorien-koelemeijer/goose
that referenced
this pull request
Sep 2, 2025
Signed-off-by: Dorien Koelemeijer <dkoelemeijer@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how it worked before but verified this fixes eleven labs not working locally and also the issue with the ui not respecting the previous audio provider selection.
fixes #4056