fix: openai add checking about fast model #4353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@katzdave I can bypass your OPEN_AI_DEFAULT_FAST_MODEL setting by this commit. Maybe like what you said, create a new GOOSE_FAST_MODEL variable to handle maybe more flexible. |
Collaborator
|
this will certainly fix it, but it's not really the way I think. |
shawn111
force-pushed
the
only-openai-run-fast
branch
from
5e266c1 to
23c890c
Compare
for OpenAI compatible might does't support gpt-4o-mini Signed-off-by: Shawn Wang <shawn111@gmail.com>
shawn111
force-pushed
the
only-openai-run-fast
branch
from
23c890c to
590898e
Compare
Contributor
Author
|
crates/goose/src/providers/databricks.rs did some similar check about fast model |
shawn111
changed the title
Contributor
Author
|
It is fixed by Fast model falls back to regular #4375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for OpenAI compatible might does't support gpt-4o-mini
it can fix #4350