feat: integrate tool call icons with status indicators and daisy chaining #4279
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import { formatMessageTimestamp } from '../utils/timeUtils'; | ||
| import { Message, getToolRequests } from '../types/message'; | ||
| import { NotificationEvent } from '../hooks/useMessageStream'; | ||
| import ToolCallWithResponse from './ToolCallWithResponse'; | ||
|
|
||
| interface ToolCallChainProps { | ||
| messages: Message[]; | ||
| chainIndices: number[]; | ||
| toolCallNotifications: Map<string, NotificationEvent[]>; | ||
| toolResponsesMap: Map<string, import('../types/message').ToolResponseMessageContent>; | ||
| messageHistoryIndex: number; | ||
| isStreaming?: boolean; | ||
| } | ||
|
|
||
| export default function ToolCallChain({ | ||
| messages, | ||
| chainIndices, | ||
| toolCallNotifications, | ||
| toolResponsesMap, | ||
| messageHistoryIndex, | ||
| isStreaming = false, | ||
| }: ToolCallChainProps) { | ||
| const lastMessageIndex = chainIndices[chainIndices.length - 1]; | ||
| const lastMessage = messages[lastMessageIndex]; | ||
| const timestamp = lastMessage ? formatMessageTimestamp(lastMessage.created) : ''; | ||
|
|
||
| return ( | ||
| <div className="relative flex flex-col w-full"> | ||
| <div className="flex flex-col gap-3"> | ||
| {chainIndices.map((messageIndex) => { | ||
| const message = messages[messageIndex]; | ||
| const toolRequests = getToolRequests(message); | ||
|
|
||
| return toolRequests.map((toolRequest) => ( | ||
| <div key={toolRequest.id} className="goose-message-tool"> | ||
| <ToolCallWithResponse | ||
| isCancelledMessage={ | ||
| messageIndex < messageHistoryIndex && | ||
| toolResponsesMap.get(toolRequest.id) == undefined | ||
| } | ||
| toolRequest={toolRequest} | ||
| toolResponse={toolResponsesMap.get(toolRequest.id)} | ||
| notifications={toolCallNotifications.get(toolRequest.id)} | ||
| isStreamingMessage={isStreaming} | ||
| /> | ||
| </div> | ||
| )); | ||
| })} | ||
| </div> | ||
|
|
||
| <div className="text-xs text-text-muted pt-1 transition-all duration-200 group-hover:-translate-y-4 group-hover:opacity-0"> | ||
| {!isStreaming && timestamp} | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| import React from 'react'; | ||
| import { cn } from '../utils'; | ||
|
|
||
| export type ToolCallStatus = 'pending' | 'loading' | 'success' | 'error'; | ||
|
|
||
| interface ToolCallStatusIndicatorProps { | ||
| status: ToolCallStatus; | ||
| className?: string; | ||
| } | ||
|
|
||
| export const ToolCallStatusIndicator: React.FC<ToolCallStatusIndicatorProps> = ({ | ||
| status, | ||
| className, | ||
| }) => { | ||
| const getStatusStyles = () => { | ||
| switch (status) { | ||
| case 'success': | ||
| return 'bg-green-500'; | ||
| case 'error': | ||
| return 'bg-red-500'; | ||
| case 'loading': | ||
| return 'bg-yellow-500 animate-pulse'; | ||
| case 'pending': | ||
| default: | ||
| return 'bg-gray-400'; | ||
| } | ||
| }; | ||
|
|
||
| return ( | ||
| <div | ||
| className={cn( | ||
| 'absolute -top-0.5 -right-0.5 w-2 h-2 rounded-full border border-background-default', | ||
| getStatusStyles(), | ||
| className | ||
| )} | ||
| aria-label={`Tool status: ${status}`} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| /** | ||
| * Wrapper component that adds a status indicator to a tool icon | ||
| */ | ||
| interface ToolIconWithStatusProps { | ||
| ToolIcon: React.ComponentType<{ className?: string }>; | ||
| status: ToolCallStatus; | ||
| className?: string; | ||
| } | ||
|
|
||
| export const ToolIconWithStatus: React.FC<ToolIconWithStatusProps> = ({ | ||
| ToolIcon, | ||
| status, | ||
| className, | ||
| }) => { | ||
| return ( | ||
| <div className={cn('relative inline-block', className)}> | ||
| <ToolIcon className="w-3 h-3 flex-shrink-0" /> | ||
| <ToolCallStatusIndicator status={status} /> | ||
| </div> | ||
| ); | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change part of this, a little lost as to what the functional change is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No function change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it needed though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vibes - will revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh I see regex was used within the chain logic and kept consistent @zanesq