Skip to content

fix issue where app redirects to home after initialization but user has already started a chat #4260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanesq merged 2 commits into from
Aug 21, 2025
Merged

fix issue where app redirects to home after initialization but user has already started a chat #4260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd5b8d7
fix issue where app redirects to home after initialization but user h…
zanesq Aug 21, 2025
338643c
fix test
zanesq Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ui/desktop/src/App.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Object.defineProperty(window, 'location', {
search: '',
href: 'http://localhost:3000',
origin: 'http://localhost:3000',
pathname: '/',
},
writable: true,
});
Expand Down Expand Up @@ -196,6 +197,7 @@ describe('App Component - Brand New State', () => {
vi.clearAllMocks();
window.location.hash = '';
window.location.search = '';
window.location.pathname = '/';
window.sessionStorage.clear();
window.localStorage.clear();
});
Expand Down
14 changes: 12 additions & 2 deletions ui/desktop/src/utils/appInitialization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,18 @@ export const initializeApp = async ({
}
}
}
window.location.hash = '#/';
window.history.replaceState({}, '', '#/');

// Only redirect to home if we're still on the initial empty hash or root
// This prevents redirecting users who have already navigated elsewhere during initialization
const currentHash = window.location.hash;
const currentPathname = window.location.pathname;
const isOnRootRoute =
currentPathname === '/' && (!currentHash || currentHash === '#' || currentHash === '#/');

if (isOnRootRoute) {
window.location.hash = '#/';
window.history.replaceState({}, '', '#/');
}
Copy link
Collaborator

@DOsinga DOsinga Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand this code and comment though - it seems like it says, redirect to root, but only if we are already on root?

Copy link
Collaborator Author

@zanesq zanesq Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the fallback route to home, but we only want to trigger it if the user hasn't already navigated somewhere else by the time it hits this.

};

const initializeForSessionResume = async ({
Expand Down
Loading