chore: removing little-used session sharing feature #4249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhancock
force-pushed
the
alexhancock/remove-session-sharing
branch
from
5010abe to
d54cc01
Compare
jamadeo
approved these changes
Aug 22, 2025
ui/desktop/src/main.ts
Outdated
| window.webContents.send('add-extension', pendingDeepLink); | ||
| } else if (parsedUrl.hostname === 'sessions') { | ||
| window.webContents.send('open-shared-session', pendingDeepLink); | ||
| // Shared session functionality has been removed |
Collaborator
There was a problem hiding this comment.
can remove condition completely here and below
ui/desktop/src/App.tsx
Outdated
| /> | ||
| <div className="flex justify-center items-center py-12"> | ||
| <div className="text-text-muted">Shared session functionality has been removed</div> | ||
| </div> |
Collaborator
Author
There was a problem hiding this comment.
Nope! Just had missed it
ui/desktop/src/App.tsx
Outdated
| setIsLoadingSharedSession={setIsLoadingSharedSession} | ||
| sharedSessionError={sharedSessionError} | ||
| /> | ||
| <SharedSessionRouteWrapper /> |
Collaborator
There was a problem hiding this comment.
I think the whole route can go?
alexhancock
force-pushed
the
alexhancock/remove-session-sharing
branch
from
d54cc01 to
36285c0
Compare
Merged
michaelneale
added a commit
that referenced
this pull request
Aug 24, 2025
* main: docs: Plan tutorial (#4309) Extensions Modal Improvements (#4293) docs: fixed cicd tutorial pipeline in docs (#4223) Read oltp config from config and env (#4292) release/1.6.0 (#4280) docs: fix broken links in Docker tutorial (#4285) Remove half-second wait, rework auto submit (#4282) Block send until extensions are ready (#4271) fix: improve OpenAI-compatible error handling and add test coverage (#4175) Move To-Do Tool to Session Scope from Agent Scope (#4157) fix: recipe params not being replaced all the time (#4207) chore: removing little-used session sharing feature (#4249) Stop auto scrolling when agent responds and let scroll area handle scrolling to bottom (#4257) restore cli projects from accidental removal during cleanup (#4266) Fix: deep link extension installation to show dialog for headers configuration (#4150)
michaelneale
added a commit
that referenced
this pull request
Aug 25, 2025
* main: (24 commits) feat: autovisualiser of structured data with mcp-ui (#4153) docs: Plan tutorial (#4309) Extensions Modal Improvements (#4293) docs: fixed cicd tutorial pipeline in docs (#4223) Read oltp config from config and env (#4292) release/1.6.0 (#4280) docs: fix broken links in Docker tutorial (#4285) Remove half-second wait, rework auto submit (#4282) Block send until extensions are ready (#4271) fix: improve OpenAI-compatible error handling and add test coverage (#4175) Move To-Do Tool to Session Scope from Agent Scope (#4157) fix: recipe params not being replaced all the time (#4207) chore: removing little-used session sharing feature (#4249) Stop auto scrolling when agent responds and let scroll area handle scrolling to bottom (#4257) restore cli projects from accidental removal during cleanup (#4266) Fix: deep link extension installation to show dialog for headers configuration (#4150) feat: Add message queue system with interruption handling (#4179) Start extensions concurrently (#4234) Add X-Title and referer headers on exchange to tetrate (#4250) docs: update View/Edit Recipe menu item name (#4267) ...
shellz-n-stuff
pushed a commit
to shellz-n-stuff/goose
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Alex Rosenzweig <[email protected]>
dorien-koelemeijer
pushed a commit
to dorien-koelemeijer/goose
that referenced
this pull request
Sep 2, 2025
Signed-off-by: Dorien Koelemeijer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed this recently as a group. This feature is very little used and seemingly almost entirely unused in OSS circles. Removing this implementation, and may replace soon with a simple implementation that can share a
.jsonlfile via system share menu.