Skip to content

stop replacing chat window when changing working directory #4200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanesq merged 2 commits into from
Aug 21, 2025
Merged

stop replacing chat window when changing working directory #4200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19ddac4
stop replacing chat window when changing working directory
zanesq Aug 19, 2025
44faaca
remove unneeded replace option
zanesq Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 5 additions & 44 deletions ui/desktop/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,9 +953,7 @@ const buildRecentFilesMenu = () => {
}));
};

const openDirectoryDialog = async (
replaceWindow: boolean = false
): Promise<OpenDialogReturnValue> => {
const openDirectoryDialog = async (): Promise<OpenDialogReturnValue> => {
// Get the current working directory from the focused window
let defaultPath: string | undefined;
const currentWindow = BrowserWindow.getFocusedWindow();
Expand Down Expand Up @@ -1033,45 +1031,8 @@ const openDirectoryDialog = async (
}

addRecentDir(dirToAdd);
const currentWindow = BrowserWindow.getFocusedWindow();

if (replaceWindow && currentWindow) {
Copy link
Collaborator Author

@zanesq zanesq Aug 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was left over from when we were attempting to launch in the same window but had to change it last minute. Can bring it back when we work on unifying chat to one window

// Replace current window with new one
await createChat(app, undefined, dirToAdd);
currentWindow.close();
} else {
// Update the working directory in the current window's localStorage
if (currentWindow) {
try {
const updateConfigScript = `
try {
const currentConfig = JSON.parse(localStorage.getItem('gooseConfig') || '{}');
const updatedConfig = {
...currentConfig,
GOOSE_WORKING_DIR: '${dirToAdd.replace(/'/g, "\\'")}',
};
localStorage.setItem('gooseConfig', JSON.stringify(updatedConfig));

// Trigger a config update event so the UI can refresh
window.dispatchEvent(new CustomEvent('goose-config-updated', {
detail: { GOOSE_WORKING_DIR: '${dirToAdd.replace(/'/g, "\\'")}' }
}));
} catch (e) {
console.error('Failed to update working directory in localStorage:', e);
}
`;
await currentWindow.webContents.executeJavaScript(updateConfigScript);
console.log(`Updated working directory to: ${dirToAdd}`);
} catch (error) {
console.error('Failed to update working directory:', error);
// Fallback: create new window
await createChat(app, undefined, dirToAdd);
}
} else {
// No current window, create new one
await createChat(app, undefined, dirToAdd);
}
}
// Create a new window with the selected directory
await createChat(app, undefined, dirToAdd);
}
return result;
};
Expand Down Expand Up @@ -1110,8 +1071,8 @@ ipcMain.on('react-ready', () => {
});

// Handle directory chooser
ipcMain.handle('directory-chooser', (_event, replace: boolean = false) => {
return openDirectoryDialog(replace);
ipcMain.handle('directory-chooser', (_event) => {
return openDirectoryDialog();
});

// Handle scheduling engine settings
Expand Down
2 changes: 1 addition & 1 deletion ui/desktop/src/preload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ const electronAPI: ElectronAPI = {
return config;
},
hideWindow: () => ipcRenderer.send('hide-window'),
directoryChooser: (replace?: boolean) => ipcRenderer.invoke('directory-chooser', replace),
directoryChooser: () => ipcRenderer.invoke('directory-chooser'),
createChatWindow: (
query?: string,
dir?: string,
Expand Down
Loading