-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add PKCE support for Tetrate Agent Router Service #4165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3284865 to
8f3774a
Compare
|
ok I pushed a fix to your branch to make it compile (small change on main with api) - but I can't seem to make it work with credits (I think). I can sign on, allw orks great, but I have 0 credit so it fails with an error message if I try to use it. In one case I used github, in another used my gmail - which I guess would be most obvious things people do - is there something else we need to do? I assume due to a balance of zero (I can see it in both accounts if I log in)? (it would need a non zero balance for it to work I guess?) - or am I seeing another bug with the flow and it didn't save the token? |
| @@ -0,0 +1,349 @@ | |||
| use anyhow::{Error, Result}; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense, as there is some tetrate specific handling between models going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to simplify this a bit. We don't use the same prefixes and I don't think we need the cache control portion for anthropic either.
I followed this pattern from the openrouter one as I think we may find some nuances in model handling as we test. If we don't have a need for this, I can pull it out in favor a more generic openai compat provider or something like that.
|
so far - seems ok, follows exactly the same patterns as the openrouter sign up with PKCE |
I believe that TARS is set to give $5 credits to business emails at the moment. Let me know if you need me to arrange for some credits to test on the backend. |
|
thanks @johnlanda looks like a bit of conflict resolving to do still - some deeper changes on main, if you get to it? but looking good. |
Signed-off-by: John Landa <[email protected]>
Signed-off-by: John Landa <[email protected]>
Signed-off-by: John Landa <[email protected]>
Signed-off-by: John Landa <[email protected]>
|
@michaelneale I think I have all the conflicts sorted with the latest on main. Let me know if you have a chance to take another look! |
Signed-off-by: John Landa <[email protected]>
|
taking a look shortly! |
|
thanks @johnlanda - if you ask goose to run ./scripts/clippy-lint.sh and fix it - it will take care of those final things. |
Signed-off-by: John Landa <[email protected]>
|
oh sometimes to see the test codepath errors I need to run |
Signed-off-by: John Landa <[email protected]>
…-pkce-tars * 'pkce-tars' of github.com:johnlanda/goose: test cleanup run clippy lint script cargo fmt Simplify tetrate provider fmt Add ui PKCE flow for TARS Add PKCE support for Tetrate Agent Router Service
|
ok this looks really great.
could make this the recommended one, especially if it sends people to sign up to get the credits @johnlanda could change some wording, and make tetrate recommended? Wording could be similar to openrouter "get instant access to AI models, get started for free, automatically configured"? also is there an icon to use? |
|
ok changed some wording and updated:
cc @spencrmartin this has now another card - which pushes "others" below the fold I believe - any thoughts on that? |
michaelneale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested it every which way, and works well. Some follow ons before promoting to make sure people get sent to the right "get free credit" path, but very nice!
* main: Add PKCE support for Tetrate Agent Router Service (#4165) Read AGENTS.md by default (#4232) docs: configure provider and model (#4235) docs: add figma tutorial (#4231) Add Nix flake for reproducible builds (#4213) Enhanced onboarding page visual design (#4156) feat: adds mtls to all providers (#2794) (#2799)
* 'main' of github.com:block/goose: chore: upgrade rmcp to 0.6.0 (#4243) doc: uvx not npx (#4240) Add PKCE support for Tetrate Agent Router Service (#4165) Read AGENTS.md by default (#4232) docs: configure provider and model (#4235) docs: add figma tutorial (#4231) Add Nix flake for reproducible builds (#4213) Enhanced onboarding page visual design (#4156) feat: adds mtls to all providers (#2794) (#2799) Don't show a confirm dialog for quitting (#4225) Fix: Missing smart_approve in CLI /mode help text and error message (#4132)
* main: (108 commits) Remove unused game (#4226) fix issue where app redirects to home after initialization but user has already started a chat (#4260) Feat: Let providers configure a fast model for summarization (#4228) docs: update tool selection strategy (#4258) feat: upgrade `@mcp-ui/client` package and improve UI message handling (#4164) stop replacing chat window when changing working directory (#4200) Only fetch session tokens when chat state is idle to avoid resetting during streaming (#4104) bump timeouts for e2e tests (#4251) docs: custom context files improvements (#4096) chore: upgrade rmcp to 0.6.0 (#4243) doc: uvx not npx (#4240) Add PKCE support for Tetrate Agent Router Service (#4165) Read AGENTS.md by default (#4232) docs: configure provider and model (#4235) docs: add figma tutorial (#4231) Add Nix flake for reproducible builds (#4213) Enhanced onboarding page visual design (#4156) feat: adds mtls to all providers (#2794) (#2799) Don't show a confirm dialog for quitting (#4225) Fix: Missing smart_approve in CLI /mode help text and error message (#4132) ...
* main: docs: update View/Edit Recipe menu item name (#4267) Remove unused game (#4226) fix issue where app redirects to home after initialization but user has already started a chat (#4260) Feat: Let providers configure a fast model for summarization (#4228) docs: update tool selection strategy (#4258) feat: upgrade `@mcp-ui/client` package and improve UI message handling (#4164) stop replacing chat window when changing working directory (#4200) Only fetch session tokens when chat state is idle to avoid resetting during streaming (#4104) bump timeouts for e2e tests (#4251) docs: custom context files improvements (#4096) chore: upgrade rmcp to 0.6.0 (#4243) doc: uvx not npx (#4240) Add PKCE support for Tetrate Agent Router Service (#4165) Read AGENTS.md by default (#4232) docs: configure provider and model (#4235)
* main: (42 commits) feat: Add message queue system with interruption handling (#4179) Start extensions concurrently (#4234) Add X-Title and referer headers on exchange to tetrate (#4250) docs: update View/Edit Recipe menu item name (#4267) Remove unused game (#4226) fix issue where app redirects to home after initialization but user has already started a chat (#4260) Feat: Let providers configure a fast model for summarization (#4228) docs: update tool selection strategy (#4258) feat: upgrade `@mcp-ui/client` package and improve UI message handling (#4164) stop replacing chat window when changing working directory (#4200) Only fetch session tokens when chat state is idle to avoid resetting during streaming (#4104) bump timeouts for e2e tests (#4251) docs: custom context files improvements (#4096) chore: upgrade rmcp to 0.6.0 (#4243) doc: uvx not npx (#4240) Add PKCE support for Tetrate Agent Router Service (#4165) Read AGENTS.md by default (#4232) docs: configure provider and model (#4235) docs: add figma tutorial (#4231) Add Nix flake for reproducible builds (#4213) ...
Signed-off-by: John Landa <[email protected]> Co-authored-by: Michael Neale <[email protected]> Signed-off-by: Dorien Koelemeijer <[email protected]>


Adds PKCE support for Tetrate Agent Router Service, similar to openrouter PKCE signup flow
Tetrate when signed up via a "work address" currently will give goose users starter credit, which is ideal.